scsi: ufs: qcom: add missing MODULE_DESCRIPTION() macro

Commit Message

Jeff Johnson June 13, 2024, 4:46 a.m. UTC

With ARCH=arm64, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/ufs/host/ufs-qcom.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <[e-mail]>
---
 drivers/ufs/host/ufs-qcom.c | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240612-md-drivers-ufs-host-a8a0aad539f0

Comments

Bart Van Assche June 13, 2024, 4:19 p.m. UTC | #1

On 6/12/24 9:46 PM, Jeff Johnson wrote:
> +MODULE_DESCRIPTION("QCOM specific hooks to UFS controller platform driver");
>   MODULE_LICENSE("GPL v2");

That sounds weird to me. I think we are better of with no module
description than with the above description.

How about the following description?

"Qualcomm UFS host controller driver".

Thanks,

Bart.

Jeff Johnson June 13, 2024, 11:18 p.m. UTC | #2

On 6/13/2024 9:19 AM, Bart Van Assche wrote:
> On 6/12/24 9:46 PM, Jeff Johnson wrote:
>> +MODULE_DESCRIPTION("QCOM specific hooks to UFS controller platform driver");
>>   MODULE_LICENSE("GPL v2");
> 
> That sounds weird to me. I think we are better of with no module
> description than with the above description.
> 
> How about the following description?
> 
> "Qualcomm UFS host controller driver".

Sounds good to me. Will spin a v2.

Patch

diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index cca190d1c577..72f95e2779ce 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -1883,4 +1883,5 @@  static struct platform_driver ufs_qcom_pltform = {
 };
 module_platform_driver(ufs_qcom_pltform);
 
+MODULE_DESCRIPTION("QCOM specific hooks to UFS controller platform driver");
 MODULE_LICENSE("GPL v2");