mbox series

[net-next,v5,00/12] net: dsa: lantiq_gswip: code improvements

Message ID 20240611135434.3180973-1-ms@dev.tdt.de (mailing list archive)
Headers show
Series net: dsa: lantiq_gswip: code improvements | expand

Message

Martin Schiller June 11, 2024, 1:54 p.m. UTC
This patchset for the lantiq_gswip driver is a collection of minor fixes
and coding improvements by Martin Blumenstingl without any real changes
in the actual functionality.

=== Changelog ===
From v4:
- merge dt-bindings patches to satisfy 'make dt_bindings_check' and add
  some improvements suggested by Rob Herring

From v3:
- convert lantiq,gswip bindings to YAML schema
- Add Hauke's acked-by as mentioned in the cover letter in v1

From v2:
- removed unused variable max_ports in gswip_add_single_port_br()

From v1:
- signal that we only update example code in dt-bindings
- don't use the word 'fix' if not appropriate
- new patch: add terminating '\n' where missing
- renamed MAC_BRIDGE macros to make it obvious which register field is
  used
- new patch: remove dead code from gswip_add_single_port_br()
- updated error message if FID not found in gswip_port_fdb()

Martin Blumenstingl (8):
  net: dsa: lantiq_gswip: Only allow phy-mode = "internal" on the CPU
    port
  net: dsa: lantiq_gswip: Use dev_err_probe where appropriate
  net: dsa: lantiq_gswip: Don't manually call gswip_port_enable()
  net: dsa: lantiq_gswip: Use dsa_is_cpu_port() in
    gswip_port_change_mtu()
  net: dsa: lantiq_gswip: Change literal 6 to ETH_ALEN
  net: dsa: lantiq_gswip: Consistently use macros for the mac bridge
    table
  net: dsa: lantiq_gswip: Update comments in gswip_port_vlan_filtering()
  net: dsa: lantiq_gswip: Improve error message in gswip_port_fdb()

Martin Schiller (4):
  dt-bindings: net: dsa: lantiq,gswip: convert to YAML schema
  net: dsa: lantiq_gswip: add terminating \n where missing
  net: dsa: lantiq_gswip: do also enable or disable cpu port
  net: dsa: lantiq_gswip: Remove dead code from
    gswip_add_single_port_br()

 .../bindings/net/dsa/lantiq,gswip.yaml        | 202 ++++++++++++++++++
 .../bindings/net/dsa/lantiq-gswip.txt         | 146 -------------
 MAINTAINERS                                   |   1 +
 drivers/net/dsa/lantiq_gswip.c                | 123 +++++------
 4 files changed, 258 insertions(+), 214 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt

Comments

Jakub Kicinski June 12, 2024, 2 a.m. UTC | #1
On Tue, 11 Jun 2024 15:54:22 +0200 Martin Schiller wrote:
> This patchset for the lantiq_gswip driver is a collection of minor fixes
> and coding improvements by Martin Blumenstingl without any real changes
> in the actual functionality.

For future reference:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr
Martin Schiller June 12, 2024, 12:50 p.m. UTC | #2
On 2024-06-12 04:00, Jakub Kicinski wrote:
> On Tue, 11 Jun 2024 15:54:22 +0200 Martin Schiller wrote:
>> This patchset for the lantiq_gswip driver is a collection of minor 
>> fixes
>> and coding improvements by Martin Blumenstingl without any real 
>> changes
>> in the actual functionality.
> 
> For future reference:
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr

I think you refer to "don’t repost your patches within one 24h period".

Sorry for that.
patchwork-bot+netdevbpf@kernel.org June 14, 2024, 12:20 a.m. UTC | #3
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 11 Jun 2024 15:54:22 +0200 you wrote:
> This patchset for the lantiq_gswip driver is a collection of minor fixes
> and coding improvements by Martin Blumenstingl without any real changes
> in the actual functionality.
> 
> === Changelog ===
> From v4:
> - merge dt-bindings patches to satisfy 'make dt_bindings_check' and add
>   some improvements suggested by Rob Herring
> 
> [...]

Here is the summary with links:
  - [net-next,v5,01/12] dt-bindings: net: dsa: lantiq,gswip: convert to YAML schema
    https://git.kernel.org/netdev/net-next/c/c7f75954212b
  - [net-next,v5,02/12] net: dsa: lantiq_gswip: Only allow phy-mode = "internal" on the CPU port
    https://git.kernel.org/netdev/net-next/c/b98f122ebdac
  - [net-next,v5,03/12] net: dsa: lantiq_gswip: add terminating \n where missing
    https://git.kernel.org/netdev/net-next/c/dd6d364e1895
  - [net-next,v5,04/12] net: dsa: lantiq_gswip: Use dev_err_probe where appropriate
    https://git.kernel.org/netdev/net-next/c/1763b155da02
  - [net-next,v5,05/12] net: dsa: lantiq_gswip: Don't manually call gswip_port_enable()
    https://git.kernel.org/netdev/net-next/c/f5ebf9ab6094
  - [net-next,v5,06/12] net: dsa: lantiq_gswip: do also enable or disable cpu port
    https://git.kernel.org/netdev/net-next/c/86b9ea6412af
  - [net-next,v5,07/12] net: dsa: lantiq_gswip: Use dsa_is_cpu_port() in gswip_port_change_mtu()
    https://git.kernel.org/netdev/net-next/c/7168ec1b0669
  - [net-next,v5,08/12] net: dsa: lantiq_gswip: Change literal 6 to ETH_ALEN
    https://git.kernel.org/netdev/net-next/c/c927b6e47b5c
  - [net-next,v5,09/12] net: dsa: lantiq_gswip: Consistently use macros for the mac bridge table
    https://git.kernel.org/netdev/net-next/c/e6c34597f89a
  - [net-next,v5,10/12] net: dsa: lantiq_gswip: Remove dead code from gswip_add_single_port_br()
    https://git.kernel.org/netdev/net-next/c/b068706b7831
  - [net-next,v5,11/12] net: dsa: lantiq_gswip: Update comments in gswip_port_vlan_filtering()
    https://git.kernel.org/netdev/net-next/c/e19fbe3996aa
  - [net-next,v5,12/12] net: dsa: lantiq_gswip: Improve error message in gswip_port_fdb()
    https://git.kernel.org/netdev/net-next/c/3b0a95ed7782

You are awesome, thank you!