diff mbox series

[kvm-unit-tests] gitlab-ci: Test that "make check-kerneldoc" does not report any errors

Message ID 20240607063616.60408-1-thuth@redhat.com (mailing list archive)
State New, archived
Headers show
Series [kvm-unit-tests] gitlab-ci: Test that "make check-kerneldoc" does not report any errors | expand

Commit Message

Thomas Huth June 7, 2024, 6:36 a.m. UTC
To make sure that we don't regress with the formatting of the
comments, we should check this in the CI, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .gitlab-ci.yml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Nicholas Piggin June 14, 2024, 12:45 a.m. UTC | #1
On Fri Jun 7, 2024 at 4:36 PM AEST, Thomas Huth wrote:
> To make sure that we don't regress with the formatting of the
> comments, we should check this in the CI, too.

Could make it a script, but this works well enough too.

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>

>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .gitlab-ci.yml | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 23bb69e2..2af47328 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -310,6 +310,8 @@ build-centos7:
>       setjmp sieve tsc rmap_chain umip
>       | tee results.txt
>   - grep -q PASS results.txt && ! grep -q FAIL results.txt
> + - make -s check-kerneldoc 2>&1 | tee docwarnings.txt
> + - test -z `cat docwarnings.txt`
>  
>  # Cirrus-CI provides containers with macOS and Linux with KVM enabled,
>  # so we can test some scenarios there that are not possible with the
diff mbox series

Patch

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 23bb69e2..2af47328 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -310,6 +310,8 @@  build-centos7:
      setjmp sieve tsc rmap_chain umip
      | tee results.txt
  - grep -q PASS results.txt && ! grep -q FAIL results.txt
+ - make -s check-kerneldoc 2>&1 | tee docwarnings.txt
+ - test -z `cat docwarnings.txt`
 
 # Cirrus-CI provides containers with macOS and Linux with KVM enabled,
 # so we can test some scenarios there that are not possible with the