| Message ID | 20240614213839.2532061-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [1/1] dt-bindings: gpio: mpc8xxx: Allow only use 'fsl,qoriq-gpio' | expand |
On 14/06/2024 23:38, Frank Li wrote: > Allow only use compatible string 'fsl,qoriq-gpio' in dts to fix below > warning: > > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dtb: gpio@2300000: compatible: 'oneOf' conditional failed, one must be fixed: > ['fsl,qoriq-gpio'] is too short > 'fsl,qoriq-gpio' is not one of ['fsl,mpc5121-gpio', 'fsl,mpc5125-gpio', 'fsl,mpc8349-gpio', 'fsl,mpc8572-gpio', 'fsl,mpc8610-gpio', 'fsl,pq3-gpio'] > 'fsl,qoriq-gpio' is not one of ['fsl,ls1021a-gpio', 'fsl,ls1028a-gpio', 'fsl,ls1043a-gpio', 'fsl,ls1088a-gpio', 'fsl,ls2080a-gpio'] > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/gpio/fsl,qoriq-gpio.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/gpio/fsl,qoriq-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,qoriq-gpio.yaml > index eb046a48a3f59..ef72f569c8387 100644 > --- a/Documentation/devicetree/bindings/gpio/fsl,qoriq-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/fsl,qoriq-gpio.yaml > @@ -19,6 +19,7 @@ properties: > - fsl,mpc8572-gpio > - fsl,mpc8610-gpio > - fsl,pq3-gpio > + - fsl,qoriq-gpio No, this does not look like correct fix. You rather miss specific compatibles. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/gpio/fsl,qoriq-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,qoriq-gpio.yaml index eb046a48a3f59..ef72f569c8387 100644 --- a/Documentation/devicetree/bindings/gpio/fsl,qoriq-gpio.yaml +++ b/Documentation/devicetree/bindings/gpio/fsl,qoriq-gpio.yaml @@ -19,6 +19,7 @@ properties: - fsl,mpc8572-gpio - fsl,mpc8610-gpio - fsl,pq3-gpio + - fsl,qoriq-gpio - items: - enum: - fsl,ls1021a-gpio
Allow only use compatible string 'fsl,qoriq-gpio' in dts to fix below warning: arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dtb: gpio@2300000: compatible: 'oneOf' conditional failed, one must be fixed: ['fsl,qoriq-gpio'] is too short 'fsl,qoriq-gpio' is not one of ['fsl,mpc5121-gpio', 'fsl,mpc5125-gpio', 'fsl,mpc8349-gpio', 'fsl,mpc8572-gpio', 'fsl,mpc8610-gpio', 'fsl,pq3-gpio'] 'fsl,qoriq-gpio' is not one of ['fsl,ls1021a-gpio', 'fsl,ls1028a-gpio', 'fsl,ls1043a-gpio', 'fsl,ls1088a-gpio', 'fsl,ls2080a-gpio'] Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Documentation/devicetree/bindings/gpio/fsl,qoriq-gpio.yaml | 1 + 1 file changed, 1 insertion(+)