| Message ID | 20240617024341.3106240-1-jacobe.zang@wesion.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v1] dt-bindings: net: wireless: BCM4329 binding: add pci14e4,449d | expand |
On 17/06/2024 04:43, Jacobe Zang wrote: > It's a Broadcom Wi-Fi module connected via the PCIe interface and also > add prefix in vendor-prefix.yaml You do not add prefix here. Drop unrelated parts of commit msg. > > Link:https://lore.kernel.org/linux-devicetree/20240617023517.3104427-1-jacobe.zang@wesion.com/T/#u Link also does not seem to be really relevant to the commit. No point to keep it in the git log. You can always provide additional information in the changelog section (---). > Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> > --- > .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 + > 1 file changed, 1 insertion(+) Best regards, Krzysztof
> You do not add prefix here. Drop unrelated parts of commit msg.
OK, I will remove unrelated parts. The reason why I added it is that when I do ./script/checkpatch.pl the patch, it said the compatible is not document.
---
Best Regards
Jacobe
On 6/17/2024 4:43 AM, Jacobe Zang wrote: > It's a Broadcom Wi-Fi module connected via the PCIe interface and also > add prefix in vendor-prefix.yaml > > Link:https://lore.kernel.org/linux-devicetree/20240617023517.3104427-1-jacobe.zang@wesion.com/T/#u > Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> > --- > .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > index e564f20d8f415..0477566acd72a 100644 > --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > @@ -53,6 +53,7 @@ properties: > - pci14e4,4488 # BCM4377 > - pci14e4,4425 # BCM4378 > - pci14e4,4433 # BCM4387 > + - pci14e4,449d # BCM4329 I can not find that device id. Can you provide more information where you came across this device. The BCM4329 as I know it is an 802.11n *SDIO* device. Not a PCI device. Regards, Arend
Hi, On Tue, Jun 18, 2024 at 01:09:07PM GMT, Arend Van Spriel wrote: > On 6/17/2024 4:43 AM, Jacobe Zang wrote: > > It's a Broadcom Wi-Fi module connected via the PCIe interface and also > > add prefix in vendor-prefix.yaml > > > > Link:https://lore.kernel.org/linux-devicetree/20240617023517.3104427-1-jacobe.zang@wesion.com/T/#u > > Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> > > --- > > .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > > index e564f20d8f415..0477566acd72a 100644 > > --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > > @@ -53,6 +53,7 @@ properties: > > - pci14e4,4488 # BCM4377 > > - pci14e4,4425 # BCM4378 > > - pci14e4,4433 # BCM4387 > > + - pci14e4,449d # BCM4329 > > I can not find that device id. Can you provide more information where you > came across this device. The BCM4329 as I know it is an 802.11n *SDIO* > device. Not a PCI device. It's the device id used by AP6275P, see this discussion from half a year ago [0]. It is used by Rockchip's RK3588 evaluation board, which apparently resulted in some RK3588 boards using the same chip. [0] https://patchwork.kernel.org/project/linux-wireless/patch/c7b331edd65b66521a6605177d654e55051568a3.camel@toradex.com/ Greetings, -- Sebastian
diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml index e564f20d8f415..0477566acd72a 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml @@ -53,6 +53,7 @@ properties: - pci14e4,4488 # BCM4377 - pci14e4,4425 # BCM4378 - pci14e4,4433 # BCM4387 + - pci14e4,449d # BCM4329 reg: description: SDIO function number for the device (for most cases
It's a Broadcom Wi-Fi module connected via the PCIe interface and also add prefix in vendor-prefix.yaml Link:https://lore.kernel.org/linux-devicetree/20240617023517.3104427-1-jacobe.zang@wesion.com/T/#u Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> --- .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 + 1 file changed, 1 insertion(+)