| Message ID | 20240611222659.256476-2-tytso@mit.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-v2,1/2] ext4/045: use the large_dir feature to fix test failures with a 1k block size | expand |
On Tue, Jun 11, 2024 at 06:26:59PM -0400, Theodore Ts'o wrote: > This test uses dm-log-writes to test power fail scenarios, so it won't > work if the file system doesn't support metadata journaling. > > Signed-off-by: Theodore Ts'o <tytso@mit.edu> > --- > tests/generic/455 | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/generic/455 b/tests/generic/455 > index da803de08..6dce8a659 100755 > --- a/tests/generic/455 > +++ b/tests/generic/455 > @@ -65,6 +65,9 @@ _log_writes_init $DMTHIN_VOL_DEV > > _log_writes_mkfs >> $seqres.full 2>&1 > > +# This test requires metadata journaling since it simulates a power failure > +_require_metadata_journaling "$LOGWRITES_DMDEV" Good to me, Thanks! Reviewed-by: Zorro Lang <zlang@redhat.com> > + > # Log writes emulates discard support, turn it on for maximum crying. > _log_writes_mount -o discard > > -- > 2.43.0 > >
diff --git a/tests/generic/455 b/tests/generic/455 index da803de08..6dce8a659 100755 --- a/tests/generic/455 +++ b/tests/generic/455 @@ -65,6 +65,9 @@ _log_writes_init $DMTHIN_VOL_DEV _log_writes_mkfs >> $seqres.full 2>&1 +# This test requires metadata journaling since it simulates a power failure +_require_metadata_journaling "$LOGWRITES_DMDEV" + # Log writes emulates discard support, turn it on for maximum crying. _log_writes_mount -o discard
This test uses dm-log-writes to test power fail scenarios, so it won't work if the file system doesn't support metadata journaling. Signed-off-by: Theodore Ts'o <tytso@mit.edu> --- tests/generic/455 | 3 +++ 1 file changed, 3 insertions(+)