| Message ID | 20240617104326.3522535-2-e@80x24.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8270201971e4ff58656065485c0fd92adddbca18 |
| Headers | show |
| Series | cat-file related doc and test | expand |
Eric Wong <e@80x24.org> writes: > command_bidi_pipe takes the git command and optional arguments as an > array, not a string. Make sure the documentation example is usable > code. Makes sense. > > Signed-off-by: Eric Wong <e@80x24.org> > --- > perl/Git.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/perl/Git.pm b/perl/Git.pm > index 03bf570bf4..aebfe0c6e0 100644 > --- a/perl/Git.pm > +++ b/perl/Git.pm > @@ -418,7 +418,7 @@ sub command_bidi_pipe { > and it is the fourth value returned by C<command_bidi_pipe()>. The call idiom > is: > > - my ($pid, $in, $out, $ctx) = $r->command_bidi_pipe('cat-file --batch-check'); > + my ($pid, $in, $out, $ctx) = $r->command_bidi_pipe(qw(cat-file --batch-check)); > print $out "000000000\n"; > while (<$in>) { ... } > $r->command_close_bidi_pipe($pid, $in, $out, $ctx); > @@ -431,7 +431,7 @@ sub command_bidi_pipe { > calling this function. This may be useful in a query-response type of > commands where caller first writes a query and later reads response, eg: > > - my ($pid, $in, $out, $ctx) = $r->command_bidi_pipe('cat-file --batch-check'); > + my ($pid, $in, $out, $ctx) = $r->command_bidi_pipe(qw(cat-file --batch-check)); > print $out "000000000\n"; > close $out; > while (<$in>) { ... }
diff --git a/perl/Git.pm b/perl/Git.pm index 03bf570bf4..aebfe0c6e0 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -418,7 +418,7 @@ sub command_bidi_pipe { and it is the fourth value returned by C<command_bidi_pipe()>. The call idiom is: - my ($pid, $in, $out, $ctx) = $r->command_bidi_pipe('cat-file --batch-check'); + my ($pid, $in, $out, $ctx) = $r->command_bidi_pipe(qw(cat-file --batch-check)); print $out "000000000\n"; while (<$in>) { ... } $r->command_close_bidi_pipe($pid, $in, $out, $ctx); @@ -431,7 +431,7 @@ sub command_bidi_pipe { calling this function. This may be useful in a query-response type of commands where caller first writes a query and later reads response, eg: - my ($pid, $in, $out, $ctx) = $r->command_bidi_pipe('cat-file --batch-check'); + my ($pid, $in, $out, $ctx) = $r->command_bidi_pipe(qw(cat-file --batch-check)); print $out "000000000\n"; close $out; while (<$in>) { ... }
command_bidi_pipe takes the git command and optional arguments as an array, not a string. Make sure the documentation example is usable code. Signed-off-by: Eric Wong <e@80x24.org> --- perl/Git.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)