diff mbox series

arm64: dts: ti: k3-am62a-main: Enable crypto accelerator

Message ID 20240617-crytpo-am62a-v1-1-ddb719aed71b@ti.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: ti: k3-am62a-main: Enable crypto accelerator | expand

Commit Message

Kamlesh Gurudasani June 17, 2024, 10:22 a.m. UTC 
Add the node for sa3ul crypto accelerator.

Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)


---
base-commit: 6906a84c482f098d31486df8dc98cead21cce2d0
change-id: 20240617-crytpo-am62a-bb6b71643cc7

Best regards,

Comments

Krzysztof Kozlowski June 17, 2024, 3:51 p.m. UTC | #1 
On 17/06/2024 12:22, Kamlesh Gurudasani wrote:
> Add the node for sa3ul crypto accelerator.
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> index ce4a2f105630..298d0c91fc0a 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> @@ -216,6 +216,18 @@ k3_reset: reset-controller {
>  		};
>  	};
>  
> +	crypto: crypto@40900000 {
> +		compatible = "ti,am62-sa3ul";
> +		reg = <0x00 0x40900000 0x00 0x1200>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;

Why do you need ranges? No children here.

Anyway, keep the order as in DTS coding style.


Best regards,
Krzysztof
Kamlesh Gurudasani June 18, 2024, 11:15 a.m. UTC | #2 
Krzysztof Kozlowski <krzk@kernel.org> writes:

...
>> +	crypto: crypto@40900000 {
>> +		compatible = "ti,am62-sa3ul";
>> +		reg = <0x00 0x40900000 0x00 0x1200>;
>> +		#address-cells = <2>;
>> +		#size-cells = <2>;
>> +		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
>
> Why do you need ranges? No children here.
Thanks for correcting, Krzysztof.

This got carried from a device with child node.
Sending a v2.

Kamlesh
>
> Anyway, keep the order as in DTS coding style.
>
>
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
index ce4a2f105630..298d0c91fc0a 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
@@ -216,6 +216,18 @@  k3_reset: reset-controller {
 		};
 	};
 
+	crypto: crypto@40900000 {
+		compatible = "ti,am62-sa3ul";
+		reg = <0x00 0x40900000 0x00 0x1200>;
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
+
+		dmas = <&main_pktdma 0xf501 0>, <&main_pktdma 0x7506 0>,
+		       <&main_pktdma 0x7507 0>;
+		dma-names = "tx", "rx1", "rx2";
+	};
+
 	secure_proxy_sa3: mailbox@43600000 {
 		compatible = "ti,am654-secure-proxy";
 		#mbox-cells = <1>;