| Message ID | 20231122043009.2741-16-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: renesas: vsp1: Conversion to subdev active state | expand |
Hi Laurent On Wed, Nov 22, 2023 at 06:30:05AM GMT, Laurent Pinchart wrote: > checkpatch.pl complains when function arguments are not named: > > WARNING: function definition argument 'struct vsp1_entity *' should also have an identifier name > + void (*configure_stream)(struct vsp1_entity *, > > In preparation for reworking some of the vsp1_entity_operations > functions, fix the warnings for the existing ones. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Thanks j > --- > .../media/platform/renesas/vsp1/vsp1_entity.h | 35 +++++++++++-------- > 1 file changed, 21 insertions(+), 14 deletions(-) > > diff --git a/drivers/media/platform/renesas/vsp1/vsp1_entity.h b/drivers/media/platform/renesas/vsp1/vsp1_entity.h > index f67f60677644..42000d6e2530 100644 > --- a/drivers/media/platform/renesas/vsp1/vsp1_entity.h > +++ b/drivers/media/platform/renesas/vsp1/vsp1_entity.h > @@ -77,20 +77,27 @@ struct vsp1_route { > * configuration. > */ > struct vsp1_entity_operations { > - void (*destroy)(struct vsp1_entity *); > - void (*configure_stream)(struct vsp1_entity *, struct vsp1_pipeline *, > - struct vsp1_dl_list *, struct vsp1_dl_body *); > - void (*configure_frame)(struct vsp1_entity *, struct vsp1_pipeline *, > - struct vsp1_dl_list *, struct vsp1_dl_body *); > - void (*configure_partition)(struct vsp1_entity *, > - struct vsp1_pipeline *, > - const struct vsp1_partition *, > - struct vsp1_dl_list *, > - struct vsp1_dl_body *); > - unsigned int (*max_width)(struct vsp1_entity *, struct vsp1_pipeline *); > - void (*partition)(struct vsp1_entity *, struct vsp1_pipeline *, > - struct vsp1_partition *, unsigned int, > - struct v4l2_rect *); > + void (*destroy)(struct vsp1_entity *entity); > + void (*configure_stream)(struct vsp1_entity *entity, > + struct vsp1_pipeline *pipe, > + struct vsp1_dl_list *dl, > + struct vsp1_dl_body *dlb); > + void (*configure_frame)(struct vsp1_entity *entity, > + struct vsp1_pipeline *pipe, > + struct vsp1_dl_list *dl, > + struct vsp1_dl_body *dlb); > + void (*configure_partition)(struct vsp1_entity *entity, > + struct vsp1_pipeline *pipe, > + const struct vsp1_partition *partition, > + struct vsp1_dl_list *dl, > + struct vsp1_dl_body *dlb); > + unsigned int (*max_width)(struct vsp1_entity *entity, > + struct vsp1_pipeline *pipe); > + void (*partition)(struct vsp1_entity *entity, > + struct vsp1_pipeline *pipe, > + struct vsp1_partition *partition, > + unsigned int index, > + struct v4l2_rect *window); > }; > > struct vsp1_entity { > -- > Regards, > > Laurent Pinchart > >
diff --git a/drivers/media/platform/renesas/vsp1/vsp1_entity.h b/drivers/media/platform/renesas/vsp1/vsp1_entity.h index f67f60677644..42000d6e2530 100644 --- a/drivers/media/platform/renesas/vsp1/vsp1_entity.h +++ b/drivers/media/platform/renesas/vsp1/vsp1_entity.h @@ -77,20 +77,27 @@ struct vsp1_route { * configuration. */ struct vsp1_entity_operations { - void (*destroy)(struct vsp1_entity *); - void (*configure_stream)(struct vsp1_entity *, struct vsp1_pipeline *, - struct vsp1_dl_list *, struct vsp1_dl_body *); - void (*configure_frame)(struct vsp1_entity *, struct vsp1_pipeline *, - struct vsp1_dl_list *, struct vsp1_dl_body *); - void (*configure_partition)(struct vsp1_entity *, - struct vsp1_pipeline *, - const struct vsp1_partition *, - struct vsp1_dl_list *, - struct vsp1_dl_body *); - unsigned int (*max_width)(struct vsp1_entity *, struct vsp1_pipeline *); - void (*partition)(struct vsp1_entity *, struct vsp1_pipeline *, - struct vsp1_partition *, unsigned int, - struct v4l2_rect *); + void (*destroy)(struct vsp1_entity *entity); + void (*configure_stream)(struct vsp1_entity *entity, + struct vsp1_pipeline *pipe, + struct vsp1_dl_list *dl, + struct vsp1_dl_body *dlb); + void (*configure_frame)(struct vsp1_entity *entity, + struct vsp1_pipeline *pipe, + struct vsp1_dl_list *dl, + struct vsp1_dl_body *dlb); + void (*configure_partition)(struct vsp1_entity *entity, + struct vsp1_pipeline *pipe, + const struct vsp1_partition *partition, + struct vsp1_dl_list *dl, + struct vsp1_dl_body *dlb); + unsigned int (*max_width)(struct vsp1_entity *entity, + struct vsp1_pipeline *pipe); + void (*partition)(struct vsp1_entity *entity, + struct vsp1_pipeline *pipe, + struct vsp1_partition *partition, + unsigned int index, + struct v4l2_rect *window); }; struct vsp1_entity {
checkpatch.pl complains when function arguments are not named: WARNING: function definition argument 'struct vsp1_entity *' should also have an identifier name + void (*configure_stream)(struct vsp1_entity *, In preparation for reworking some of the vsp1_entity_operations functions, fix the warnings for the existing ones. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- .../media/platform/renesas/vsp1/vsp1_entity.h | 35 +++++++++++-------- 1 file changed, 21 insertions(+), 14 deletions(-)