| Message ID | 87bk4oqerx.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: grace time for DPCM cleanup | expand |
On Thu, May 30, 2024 at 01:17:39AM +0000, Kuninori Morimoto wrote: > As we discussed in [1], we don't need to use dpcm_playback/capture flag, > so we remove it. But we have been using it for 10 years, some driver might > get damage. The most likely case is that the device/driver can use both > playback/capture, but have only one flag, and not using xxx_only flag. > [1/3] patch indicates warning in such case. This doesn't apply against current code, please check and resend (it's simple-card and audio-graph-card2 that conflict).
Hi Mark > > As we discussed in [1], we don't need to use dpcm_playback/capture flag, > > so we remove it. But we have been using it for 10 years, some driver might > > get damage. The most likely case is that the device/driver can use both > > playback/capture, but have only one flag, and not using xxx_only flag. > > [1/3] patch indicates warning in such case. > > This doesn't apply against current code, please check and resend (it's > simple-card and audio-graph-card2 that conflict). Hmm ? I didn't get conflict on latest branch ? I'm using this commit 595265c92668cbdbd9f299c49907734d468c12e9 ("ASoC: Constify DAI ops auto_selectable_formats") Anyway, I will post v6 patch. Thank you for your help !! Best regards --- Kuninori Morimoto
Hi Mark again > > As we discussed in [1], we don't need to use dpcm_playback/capture flag, > > so we remove it. But we have been using it for 10 years, some driver might > > get damage. The most likely case is that the device/driver can use both > > playback/capture, but have only one flag, and not using xxx_only flag. > > [1/3] patch indicates warning in such case. > > This doesn't apply against current code, please check and resend (it's > simple-card and audio-graph-card2 that conflict). Ah, I guess you used "v5 original" patch-set. "v5 resend" patch-set or today's "v6" patch-set should be OK. Thank you for your help !! Best regards --- Kuninori Morimoto
On Wed, Jun 19, 2024 at 04:57:22AM +0000, Kuninori Morimoto wrote: > > This doesn't apply against current code, please check and resend (it's > > simple-card and audio-graph-card2 that conflict). > Ah, I guess you used "v5 original" patch-set. > "v5 resend" patch-set or today's "v6" patch-set should be OK. Oh, if you mark something as a resend then it sounds like it should be exactly the same as it was before, if you've rebased you should increase the version number.
Hi Mark > > > This doesn't apply against current code, please check and resend (it's > > > simple-card and audio-graph-card2 that conflict). > > > Ah, I guess you used "v5 original" patch-set. > > "v5 resend" patch-set or today's "v6" patch-set should be OK. > > Oh, if you mark something as a resend then it sounds like it should be > exactly the same as it was before, if you've rebased you should increase > the version number. Thanks, I learned it this time. Will do since next time. And now I could understand the reason that sometime maintainer get strange conflict which I don't have :) Thank you for your help !! Best regards --- Kuninori Morimoto
On Thu, 30 May 2024 01:17:39 +0000, Kuninori Morimoto wrote: > Cc each ASoC driver maintainer > > This is v5 of DPCM cleanup > > As we discussed in [1], we don't need to use dpcm_playback/capture flag, > so we remove it. But we have been using it for 10 years, some driver might > get damage. The most likely case is that the device/driver can use both > playback/capture, but have only one flag, and not using xxx_only flag. > [1/3] patch indicates warning in such case. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/4] ASoC: soc-pcm: Indicate warning if dpcm_playback/capture were used for availability limition commit: fd69dfe6789f4ed46d1fdb52e223cff83946d997 [2/4] ASoC: remove snd_soc_dai_link_set_capabilities() commit: 12806510481497a01d01edd64d7bb53a4d9ec28d [3/4] ASoC: amlogic: do not use dpcm_playback/capture flags commit: 46fb727a28d8c7195f915150a669d927d463069b [4/4] ASoC: Intel: sof_sdw: use playback/capture_only flags commit: 61e1f74f739546415570ccc1ac14e1b26afe4705 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark