| Message ID | 171867145359.793463.11533521582429286273.stgit@frogsfrogsfrogs (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/10] misc: split swapext and exchangerange | expand |
On Mon, Jun 17, 2024 at 05:47:48PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > The latest draft of the EXCHANGERANGE ioctl has dropped the flag that > enforced that the two files being operated upon were exactly the same > length as was specified in the ioctl parameters. Remove this check > since it's now defunct. The last draft is what got merged into 6.10-rc as far as I can tell, so maybe update the commit message for that? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>
On Tue, Jun 18, 2024 at 11:09:22PM -0700, Christoph Hellwig wrote: > On Mon, Jun 17, 2024 at 05:47:48PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@kernel.org> > > > > The latest draft of the EXCHANGERANGE ioctl has dropped the flag that > > enforced that the two files being operated upon were exactly the same > > length as was specified in the ioctl parameters. Remove this check > > since it's now defunct. > > The last draft is what got merged into 6.10-rc as far as I can tell, > so maybe update the commit message for that? "The final version of the EXCHANGERANGE ioctl..." > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@lst.de> Thanks! --D
On Wed, Jun 19, 2024 at 09:31:48AM -0700, Darrick J. Wong wrote: > On Tue, Jun 18, 2024 at 11:09:22PM -0700, Christoph Hellwig wrote: > > On Mon, Jun 17, 2024 at 05:47:48PM -0700, Darrick J. Wong wrote: > > > From: Darrick J. Wong <djwong@kernel.org> > > > > > > The latest draft of the EXCHANGERANGE ioctl has dropped the flag that > > > enforced that the two files being operated upon were exactly the same > > > length as was specified in the ioctl parameters. Remove this check > > > since it's now defunct. > > > > The last draft is what got merged into 6.10-rc as far as I can tell, > > so maybe update the commit message for that? > > "The final version of the EXCHANGERANGE ioctl..." Will change "The latest draft" to "The final version" when I merge it. Thanks, Zorro > > > Otherwise looks good: > > > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > Thanks! > > --D >
diff --git a/tests/generic/717 b/tests/generic/717 index ffabe2eaa1..7bc917e555 100755 --- a/tests/generic/717 +++ b/tests/generic/717 @@ -77,11 +77,6 @@ $XFS_IO_PROG -c "exchangerange -d 0 -s $(( blksz * nrblks )) -l 37 $dir/b" $dir/ echo file2 unaligned EOF to file1 nowhere near EOF $XFS_IO_PROG -c "exchangerange -s 0 -d $(( blksz * nrblks )) -l 37 $dir/b" $dir/a -echo Files of unequal length -_pwrite_byte 0x58 $((blksz * nrblks)) $((blksz * 2)) $dir/a >> $seqres.full -_pwrite_byte 0x59 $((blksz * nrblks)) $blksz $dir/b >> $seqres.full -$XFS_IO_PROG -c "exchangerange $dir/b" $dir/a - echo Files on different filesystems _pwrite_byte 0x58 0 $((blksz * nrblks)) $SCRATCH_MNT/c >> $seqres.full $XFS_IO_PROG -c "exchangerange $SCRATCH_MNT/c" $dir/a diff --git a/tests/generic/717.out b/tests/generic/717.out index 85137bf412..e2c630d6d9 100644 --- a/tests/generic/717.out +++ b/tests/generic/717.out @@ -23,8 +23,6 @@ file1 unaligned EOF to file2 nowhere near EOF exchangerange: Invalid argument file2 unaligned EOF to file1 nowhere near EOF exchangerange: Invalid argument -Files of unequal length -exchangerange: Bad address Files on different filesystems exchangerange: Invalid cross-device link Files on different mounts