| Message ID | 20240619125708.3719150-2-christian.couder@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Advertise OS version | expand |
On Wed, Jun 19, 2024 at 8:57 AM Christian Couder <christian.couder@gmail.com> wrote: > The git_user_agent_sanitized() function performs some sanitizing to > avoid special characters being sent over the line and possibly messing > up with the protocol or with the parsing on the other side. > > Let's extract this sanitizing into a new strbuf_sanitize() function, as > we will want to reuse it in a following patch. > > For now the new strbuf_sanitize() function is still static as it's only > needed locally. > > While at it, let's also make a few small improvements: > - use 'size_t' for 'i' instead of 'int', > - move the declaration of 'i' inside the 'for ( ... )', > - use strbuf_detach() to explicitely detach the string contained by > the 'buf' strbuf. s/explicitely/explicitly/ > Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
diff --git a/version.c b/version.c index 41b718c29e..331ee6c372 100644 --- a/version.c +++ b/version.c @@ -5,6 +5,15 @@ const char git_version_string[] = GIT_VERSION; const char git_built_from_commit_string[] = GIT_BUILT_FROM_COMMIT; +static void strbuf_sanitize(struct strbuf *buf) +{ + strbuf_trim(buf); + for (size_t i = 0; i < buf->len; i++) { + if (buf->buf[i] <= 32 || buf->buf[i] >= 127) + buf->buf[i] = '.'; + } +} + const char *git_user_agent(void) { static const char *agent = NULL; @@ -24,15 +33,10 @@ const char *git_user_agent_sanitized(void) if (!agent) { struct strbuf buf = STRBUF_INIT; - int i; strbuf_addstr(&buf, git_user_agent()); - strbuf_trim(&buf); - for (i = 0; i < buf.len; i++) { - if (buf.buf[i] <= 32 || buf.buf[i] >= 127) - buf.buf[i] = '.'; - } - agent = buf.buf; + strbuf_sanitize(&buf); + agent = strbuf_detach(&buf, NULL); } return agent;
The git_user_agent_sanitized() function performs some sanitizing to avoid special characters being sent over the line and possibly messing up with the protocol or with the parsing on the other side. Let's extract this sanitizing into a new strbuf_sanitize() function, as we will want to reuse it in a following patch. For now the new strbuf_sanitize() function is still static as it's only needed locally. While at it, let's also make a few small improvements: - use 'size_t' for 'i' instead of 'int', - move the declaration of 'i' inside the 'for ( ... )', - use strbuf_detach() to explicitely detach the string contained by the 'buf' strbuf. Signed-off-by: Christian Couder <chriscool@tuxfamily.org> --- version.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)