| Message ID | 20240619202659.work.532-kees@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 67c9971cd6d309ecbcb87b942e22ffc194d7a376 |
| Headers | show |
| Series | kunit/usercopy: Add missing MODULE_DESCRIPTION() | expand |
On Wed, Jun 19, 2024 at 4:27 PM Kees Cook <kees@kernel.org> wrote: > > From: Jeff Johnson <quic_jjohnson@quicinc.com> > > Fix warning seen with: > > $ make allmodconfig && make W=1 C=1 lib/usercopy_kunit.ko > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/usercopy_kunit.o > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Signed-off-by: Kees Cook <kees@kernel.org> Hi! This looks good to me. Reviewed-by: Rae Moar <rmoar@google.com> Thanks! -Rae > --- > At Jeff's reminder, I've split this out of: > https://lore.kernel.org/all/20240601-md-lib-test-v1-1-a728620e37d8@quicinc.com/ > since the file got renamed. > --- > Cc: Shuah Khan <skhan@linuxfoundation.org> > Cc: Jeff Johnson <quic_jjohnson@quicinc.com> > Cc: Brendan Higgins <brendan.higgins@linux.dev> > Cc: David Gow <davidgow@google.com> > Cc: Rae Moar <rmoar@google.com> > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: linux-kselftest@vger.kernel.org > Cc: kunit-dev@googlegroups.com > Cc: linux-hardening@vger.kernel.org > Cc: linux-mm@kvack.org > --- > lib/usercopy_kunit.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/usercopy_kunit.c b/lib/usercopy_kunit.c > index e819561a540d..77fa00a13df7 100644 > --- a/lib/usercopy_kunit.c > +++ b/lib/usercopy_kunit.c > @@ -331,4 +331,5 @@ static struct kunit_suite usercopy_test_suite = { > > kunit_test_suites(&usercopy_test_suite); > MODULE_AUTHOR("Kees Cook <kees@kernel.org>"); > +MODULE_DESCRIPTION("Kernel module for testing copy_to/from_user infrastructure"); > MODULE_LICENSE("GPL"); > -- > 2.34.1 >
On Thu, 20 Jun 2024 at 04:27, Kees Cook <kees@kernel.org> wrote: > > From: Jeff Johnson <quic_jjohnson@quicinc.com> > > Fix warning seen with: > > $ make allmodconfig && make W=1 C=1 lib/usercopy_kunit.ko > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/usercopy_kunit.o > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Signed-off-by: Kees Cook <kees@kernel.org> > --- > At Jeff's reminder, I've split this out of: > https://lore.kernel.org/all/20240601-md-lib-test-v1-1-a728620e37d8@quicinc.com/ > since the file got renamed. > --- > Cc: Shuah Khan <skhan@linuxfoundation.org> > Cc: Jeff Johnson <quic_jjohnson@quicinc.com> > Cc: Brendan Higgins <brendan.higgins@linux.dev> > Cc: David Gow <davidgow@google.com> > Cc: Rae Moar <rmoar@google.com> > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: linux-kselftest@vger.kernel.org > Cc: kunit-dev@googlegroups.com > Cc: linux-hardening@vger.kernel.org > Cc: linux-mm@kvack.org > --- Reviewed-by: David Gow <davidgow@google.com> Cheers, -- David
diff --git a/lib/usercopy_kunit.c b/lib/usercopy_kunit.c index e819561a540d..77fa00a13df7 100644 --- a/lib/usercopy_kunit.c +++ b/lib/usercopy_kunit.c @@ -331,4 +331,5 @@ static struct kunit_suite usercopy_test_suite = { kunit_test_suites(&usercopy_test_suite); MODULE_AUTHOR("Kees Cook <kees@kernel.org>"); +MODULE_DESCRIPTION("Kernel module for testing copy_to/from_user infrastructure"); MODULE_LICENSE("GPL");