| Message ID | 20240621101756.27218-1-antoniu.miclaus@analog.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2,1/3] dt-bindings: iio: accel: add ADXL380 | expand |
On 21/06/2024 12:17, Antoniu Miclaus wrote: > From: Ramona Gradinariu <ramona.gradinariu@analog.com> > > Add dt-bindings for ADXL380/ADLX382 low noise density, low > power, 3-axis accelerometer with selectable measurement ranges. > > Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> It's v2 but no changelog (no cover letter either). Were all previous issues skipped and comments ignored? Please provide proper changelog. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Friday, June 21, 2024 1:21 PM > To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; Gradinariu, Ramona > <Ramona.Gradinariu@analog.com>; Lars-Peter Clausen <lars@metafoo.de>; > Hennerich, Michael <Michael.Hennerich@analog.com>; Jonathan Cameron > <jic23@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski > <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Jonathan > Corbet <corbet@lwn.net>; Matti Vaittinen <mazziesaccount@gmail.com>; Jun > Yan <jerrysteve1101@gmail.com>; Mehdi Djait <mehdi.djait.k@gmail.com>; > Mario Limonciello <mario.limonciello@amd.com>; linux-iio@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > doc@vger.kernel.org > Subject: Re: [PATCH v2 1/3] dt-bindings: iio: accel: add ADXL380 > > [External] > > On 21/06/2024 12:17, Antoniu Miclaus wrote: > > From: Ramona Gradinariu <ramona.gradinariu@analog.com> > > > > Add dt-bindings for ADXL380/ADLX382 low noise density, low > > power, 3-axis accelerometer with selectable measurement ranges. > > > > Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com> > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > > It's v2 but no changelog (no cover letter either). Were all previous > issues skipped and comments ignored? Please provide proper changelog. Forgot to save locally the "no changes in v2" for this particular patch. My bad. The other 2 patches from this series have their changelog. Besides the change in patch nr.2, I just rebased with the togreg branch to hopefully fix the other bot detected issue (the iio_tools.rst file missing). > Best regards, > Krzysztof
On Fri, 21 Jun 2024 13:17:03 +0300 Antoniu Miclaus <antoniu.miclaus@analog.com> wrote: > From: Ramona Gradinariu <ramona.gradinariu@analog.com> > > Add dt-bindings for ADXL380/ADLX382 low noise density, low > power, 3-axis accelerometer with selectable measurement ranges. > > Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > --- > .../bindings/iio/accel/adi,adxl380.yaml | 83 +++++++++++++++++++ > MAINTAINERS | 7 ++ > 2 files changed, 90 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml > > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml > new file mode 100644 > index 000000000000..992e2ab841e2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml > @@ -0,0 +1,83 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/accel/adi,adxl380.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices ADXL380/382 3-Axis Digital Accelerometer > + > +maintainers: > + - Ramona Gradinariu <ramona.gradinariu@analog.com> > + - Antoniu Miclaus <antoniu.miclaus@analog.com> > + > +description: | > + The ADXL380/ADXL382 is a low noise density, low power, 3-axis > + accelerometer with selectable measurement ranges. The ADXL380 > + supports the ±4 g, ±8 g, and ±16 g ranges, and the ADXL382 supports > + ±15 g, ±30 g, and ±60 g ranges. > + The ADXL380/ADXL382 offers industry leading noise, enabling precision > + applications with minimal calibration. The low noise, and low power > + ADXL380/ADXL382 enables accurate measurement in an environment with > + high vibration, heart sounds and audio. > + > + In addition to its low power consumption, the ADXL380/ADXL382 has > + many features to enable true system level performance. These > + include a built-in micropower temperature sensor, single / double / > + triple tap detection and a state machine to prevent a false > + triggering. In addition, the ADXL380/ADXL382 has provisions for > + external control of the sampling time and/or an external clock. > + > + https://www.analog.com/en/products/adxl380.html > + > +properties: > + compatible: > + enum: > + - adi,adxl380 > + - adi,adxl382 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 Picture in the datasheet has 2. If that's wrong note that for now and remember to come back and update the comment when a real datasheet becomes available. > + > +required: > + - compatible > + - reg > + - interrupts No power? Magic device :) In all seriousness, I want all new bindings for IIO devices at least to include the power supplies they require to operate and make them required properties. That datasheet is less than informative "Preliminary Data sheet", but it does mention a few in the text. vsupply and vddio > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + accelerometer@54 { > + compatible = "adi,adxl380"; > + reg = <0x54>; > + interrupt-parent = <&gpio>; > + interrupts = <25 IRQ_TYPE_LEVEL_HIGH>; > + }; > + }; > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + accelerometer@0 { > + compatible = "adi,adxl380"; > + reg = <0>; > + spi-max-frequency = <8000000>; > + interrupt-parent = <&gpio>; > + interrupts = <25 IRQ_TYPE_LEVEL_HIGH>; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index be590c462d91..1425182c85e2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -618,6 +618,13 @@ F: drivers/iio/accel/adxl372.c > F: drivers/iio/accel/adxl372_i2c.c > F: drivers/iio/accel/adxl372_spi.c > > +ADXL380 THREE-AXIS DIGITAL ACCELEROMETER DRIVER > +M: Ramona Gradinariu <ramona.gradinariu@analog.com> > +M: Antoniu Miclaus <antoniu.miclaus@analog.com> > +S: Supported > +W: https://ez.analog.com/linux-software-drivers > +F: Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml > + > AF8133J THREE-AXIS MAGNETOMETER DRIVER > M: Ondřej Jirman <megi@xff.cz> > S: Maintained
diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml new file mode 100644 index 000000000000..992e2ab841e2 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml @@ -0,0 +1,83 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/accel/adi,adxl380.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices ADXL380/382 3-Axis Digital Accelerometer + +maintainers: + - Ramona Gradinariu <ramona.gradinariu@analog.com> + - Antoniu Miclaus <antoniu.miclaus@analog.com> + +description: | + The ADXL380/ADXL382 is a low noise density, low power, 3-axis + accelerometer with selectable measurement ranges. The ADXL380 + supports the ±4 g, ±8 g, and ±16 g ranges, and the ADXL382 supports + ±15 g, ±30 g, and ±60 g ranges. + The ADXL380/ADXL382 offers industry leading noise, enabling precision + applications with minimal calibration. The low noise, and low power + ADXL380/ADXL382 enables accurate measurement in an environment with + high vibration, heart sounds and audio. + + In addition to its low power consumption, the ADXL380/ADXL382 has + many features to enable true system level performance. These + include a built-in micropower temperature sensor, single / double / + triple tap detection and a state machine to prevent a false + triggering. In addition, the ADXL380/ADXL382 has provisions for + external control of the sampling time and/or an external clock. + + https://www.analog.com/en/products/adxl380.html + +properties: + compatible: + enum: + - adi,adxl380 + - adi,adxl382 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + accelerometer@54 { + compatible = "adi,adxl380"; + reg = <0x54>; + interrupt-parent = <&gpio>; + interrupts = <25 IRQ_TYPE_LEVEL_HIGH>; + }; + }; + - | + #include <dt-bindings/interrupt-controller/irq.h> + + spi { + #address-cells = <1>; + #size-cells = <0>; + + accelerometer@0 { + compatible = "adi,adxl380"; + reg = <0>; + spi-max-frequency = <8000000>; + interrupt-parent = <&gpio>; + interrupts = <25 IRQ_TYPE_LEVEL_HIGH>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index be590c462d91..1425182c85e2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -618,6 +618,13 @@ F: drivers/iio/accel/adxl372.c F: drivers/iio/accel/adxl372_i2c.c F: drivers/iio/accel/adxl372_spi.c +ADXL380 THREE-AXIS DIGITAL ACCELEROMETER DRIVER +M: Ramona Gradinariu <ramona.gradinariu@analog.com> +M: Antoniu Miclaus <antoniu.miclaus@analog.com> +S: Supported +W: https://ez.analog.com/linux-software-drivers +F: Documentation/devicetree/bindings/iio/accel/adi,adxl380.yaml + AF8133J THREE-AXIS MAGNETOMETER DRIVER M: Ondřej Jirman <megi@xff.cz> S: Maintained