| Message ID | 20240621114659.2958170-5-quic_gokulsri@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | remoteproc: qcom: q6v5-wcss: Add support for secure pil | expand |
On 21/06/2024 13:46, Gokul Sriram Palanisamy wrote: > Add name for ssr subdevice on IPQ8074 SoC. Why? > > Signed-off-by: Nikhil Prakash V <quic_nprakash@quicinc.com> > Signed-off-by: Sricharan R <quic_srichara@quicinc.com> > Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com> Three people developed that single line? Something is really odd with your DCO chain. Best regards, Krzysztof
On Fri, Jun 21, 2024 at 05:16:55PM GMT, Gokul Sriram Palanisamy wrote: > Add name for ssr subdevice on IPQ8074 SoC. Is it SSR or ssr? Why is it necessary? > > Signed-off-by: Nikhil Prakash V <quic_nprakash@quicinc.com> > Signed-off-by: Sricharan R <quic_srichara@quicinc.com> > Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com> Three authors for a single-line patch? > --- > drivers/remoteproc/qcom_q6v5_wcss.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c > index d8b79765d5c6..06936ca1d079 100644 > --- a/drivers/remoteproc/qcom_q6v5_wcss.c > +++ b/drivers/remoteproc/qcom_q6v5_wcss.c > @@ -1170,6 +1170,7 @@ static const struct wcss_data wcss_ipq8074_res_init = { > .crash_reason_smem = WCSS_CRASH_REASON, > .aon_reset_required = true, > .wcss_q6_reset_required = true, > + .ssr_name = "q6wcss", > .ops = &q6v5_wcss_ipq8074_ops, > .requires_force_stop = true, > .need_mem_protection = true, > -- > 2.34.1 >
On 25/06/2024 08:28, Gokul Sriram P wrote: > > On 6/21/2024 8:40 PM, Krzysztof Kozlowski wrote: >> On 21/06/2024 13:46, Gokul Sriram Palanisamy wrote: >>> Add name for ssr subdevice on IPQ8074 SoC. >> Why? > Oops! Missed the change. Will add and update. >>> Signed-off-by: Nikhil Prakash V<quic_nprakash@quicinc.com> >>> Signed-off-by: Sricharan R<quic_srichara@quicinc.com> >>> Signed-off-by: Gokul Sriram Palanisamy<quic_gokulsri@quicinc.com> >> Three people developed that single line? >> >> Something is really odd with your DCO chain. > The change was originally authored by Nikhil and reviewed by > Sricharan. I'm just submitting the change to upstream so retained their > names. >> Then your DCO chain is not correct. Please carefully read submitting patches, especially documents about authorship, DCO, reviewed tags. Best regards, Krzysztof
On Tue, Jun 25, 2024 at 09:04:17AM GMT, Krzysztof Kozlowski wrote: > On 25/06/2024 08:28, Gokul Sriram P wrote: > > > > On 6/21/2024 8:40 PM, Krzysztof Kozlowski wrote: > >> On 21/06/2024 13:46, Gokul Sriram Palanisamy wrote: > >>> Add name for ssr subdevice on IPQ8074 SoC. > >> Why? > > Oops! Missed the change. Will add and update. > >>> Signed-off-by: Nikhil Prakash V<quic_nprakash@quicinc.com> > >>> Signed-off-by: Sricharan R<quic_srichara@quicinc.com> > >>> Signed-off-by: Gokul Sriram Palanisamy<quic_gokulsri@quicinc.com> > >> Three people developed that single line? > >> > >> Something is really odd with your DCO chain. > > The change was originally authored by Nikhil and reviewed by > > Sricharan. I'm just submitting the change to upstream so retained their > > names. > >> > > Then your DCO chain is not correct. Please carefully read submitting > patches, especially documents about authorship, DCO, reviewed tags. Also there should be From: Nikhil header before the patch.
diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c index d8b79765d5c6..06936ca1d079 100644 --- a/drivers/remoteproc/qcom_q6v5_wcss.c +++ b/drivers/remoteproc/qcom_q6v5_wcss.c @@ -1170,6 +1170,7 @@ static const struct wcss_data wcss_ipq8074_res_init = { .crash_reason_smem = WCSS_CRASH_REASON, .aon_reset_required = true, .wcss_q6_reset_required = true, + .ssr_name = "q6wcss", .ops = &q6v5_wcss_ipq8074_ops, .requires_force_stop = true, .need_mem_protection = true,