| Message ID | 20240621-md-i386-drivers-video-console-v1-1-e533652b7ebb@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | tty: vt: add missing MODULE_DESCRIPTION() macros | expand |
On 6/22/24 08:07, Jeff Johnson wrote: > With ARCH=i386, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/console/mdacon.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro to all > files which have a MODULE_LICENSE(). > > This includes three other files which, although they did not produce a > warning with the i386 allmodconfig configuration, may cause this > warning with other configurations. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> Patch title adjusted to: video: console: add missing MODULE_DESCRIPTION() macros and applied to the fbdev git tree. Thanks, Helge > --- > drivers/video/console/mdacon.c | 1 + > drivers/video/console/newport_con.c | 1 + > drivers/video/console/sticon.c | 1 + > drivers/video/console/vgacon.c | 1 + > 4 files changed, 4 insertions(+) > > diff --git a/drivers/video/console/mdacon.c b/drivers/video/console/mdacon.c > index c0e1f4554a44..d52cd99cd18b 100644 > --- a/drivers/video/console/mdacon.c > +++ b/drivers/video/console/mdacon.c > @@ -561,5 +561,6 @@ static void __exit mda_console_exit(void) > module_init(mda_console_init); > module_exit(mda_console_exit); > > +MODULE_DESCRIPTION("MDA based console driver"); > MODULE_LICENSE("GPL"); > > diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c > index a51cfc1d560e..242415366074 100644 > --- a/drivers/video/console/newport_con.c > +++ b/drivers/video/console/newport_con.c > @@ -744,4 +744,5 @@ static struct gio_driver newport_driver = { > }; > module_driver(newport_driver, gio_register_driver, gio_unregister_driver); > > +MODULE_DESCRIPTION("SGI Newport console driver"); > MODULE_LICENSE("GPL"); > diff --git a/drivers/video/console/sticon.c b/drivers/video/console/sticon.c > index 4c7b4959a1aa..f1f3ee8e5e8a 100644 > --- a/drivers/video/console/sticon.c > +++ b/drivers/video/console/sticon.c > @@ -391,4 +391,5 @@ static int __init sticonsole_init(void) > } > > module_init(sticonsole_init); > +MODULE_DESCRIPTION("HP STI console driver"); > MODULE_LICENSE("GPL"); > diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c > index 7597f04b0dc7..37bd18730fe0 100644 > --- a/drivers/video/console/vgacon.c > +++ b/drivers/video/console/vgacon.c > @@ -1222,4 +1222,5 @@ void vgacon_register_screen(struct screen_info *si) > vga_si = si; > } > > +MODULE_DESCRIPTION("VGA based console driver"); > MODULE_LICENSE("GPL"); > > --- > base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f > change-id: 20240621-md-i386-drivers-video-console-ae292c09bb67 >
diff --git a/drivers/video/console/mdacon.c b/drivers/video/console/mdacon.c index c0e1f4554a44..d52cd99cd18b 100644 --- a/drivers/video/console/mdacon.c +++ b/drivers/video/console/mdacon.c @@ -561,5 +561,6 @@ static void __exit mda_console_exit(void) module_init(mda_console_init); module_exit(mda_console_exit); +MODULE_DESCRIPTION("MDA based console driver"); MODULE_LICENSE("GPL"); diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c index a51cfc1d560e..242415366074 100644 --- a/drivers/video/console/newport_con.c +++ b/drivers/video/console/newport_con.c @@ -744,4 +744,5 @@ static struct gio_driver newport_driver = { }; module_driver(newport_driver, gio_register_driver, gio_unregister_driver); +MODULE_DESCRIPTION("SGI Newport console driver"); MODULE_LICENSE("GPL"); diff --git a/drivers/video/console/sticon.c b/drivers/video/console/sticon.c index 4c7b4959a1aa..f1f3ee8e5e8a 100644 --- a/drivers/video/console/sticon.c +++ b/drivers/video/console/sticon.c @@ -391,4 +391,5 @@ static int __init sticonsole_init(void) } module_init(sticonsole_init); +MODULE_DESCRIPTION("HP STI console driver"); MODULE_LICENSE("GPL"); diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c index 7597f04b0dc7..37bd18730fe0 100644 --- a/drivers/video/console/vgacon.c +++ b/drivers/video/console/vgacon.c @@ -1222,4 +1222,5 @@ void vgacon_register_screen(struct screen_info *si) vga_si = si; } +MODULE_DESCRIPTION("VGA based console driver"); MODULE_LICENSE("GPL");
With ARCH=i386, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/console/mdacon.o Add the missing invocation of the MODULE_DESCRIPTION() macro to all files which have a MODULE_LICENSE(). This includes three other files which, although they did not produce a warning with the i386 allmodconfig configuration, may cause this warning with other configurations. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- drivers/video/console/mdacon.c | 1 + drivers/video/console/newport_con.c | 1 + drivers/video/console/sticon.c | 1 + drivers/video/console/vgacon.c | 1 + 4 files changed, 4 insertions(+) --- base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f change-id: 20240621-md-i386-drivers-video-console-ae292c09bb67