mbox series

[v3,0/3] ad777x driver addressing patch comments

Message ID 20240619122105.22642-1-ramona.nechita@analog.com (mailing list archive)
Headers show
Series ad777x driver addressing patch comments | expand

Message

Ramona Alexandra Nechita June 19, 2024, 12:20 p.m. UTC
This patch series is sent to address the comments received
with regards to the ad7779 driver patch:
v2-0001-drivers-iio-adc-add-support-for-ad777x-family.patch,
as well as the dt-bindings patch:
v3-0001-dt-bindings-iio-adc-add-a7779-doc.patch.
The patches were initially sent separated, this has now
been corrected with this patch series, along with soeme
other issues such as the cover letter and author.
The changes in the series:
v3:
	* drop spi-max-frequency from yaml and fix indent
	* separate ABI doc into different patch, drop ad4130
	 ABI doc file and combine the filter_mode/type properties
	 in the sysfs-bus-iio file
	* update Kconfig help section for the driver
	* update driver commit message
	* drop crc_enabled and check crc by default on all regs
	  except GEN_ERR_REG_1_EN
	* rename from "ad777x_*" to "ad7779_*"
	* switch from kfifo to triggered buffer and send w/timestamp
	* switched spidata_rx/tx buffer data type to u8 and declared
	  channels as IIO_BE
	* switched to fsleep and added comments for each of them
	* changed "____cacheline_aligned" to "__aligned(IIO_DMA_MINALIGN)"
	* fixed allignments and removed redundant variables
	* removed local update_scan_mode in favor of iio active_scan_mask
	* requested trigger as NO_AUTOEN and it is enabled/disabled only
	  in preenable/postdisable functions
	* removed separate ad777x_register function and moved the code
	  in probe
	* switched to get_clk_enabled
	* check for irq earlier in probe
	* misc code style / format changes, as suggested

Ramona Alexandra Nechita (3):
  dt-bindings: iio: adc: add a7779 doc
  Documentation: ABI: added filter mode doc in sysfs-bus-iio
  drivers: iio: adc: add support for ad777x family

 Documentation/ABI/testing/sysfs-bus-iio       |   7 +
 .../ABI/testing/sysfs-bus-iio-adc-ad4130      |  46 -
 .../bindings/iio/adc/adi,ad7779.yaml          |  84 ++
 drivers/iio/adc/Kconfig                       |  11 +
 drivers/iio/adc/Makefile                      |   1 +
 drivers/iio/adc/ad7779.c                      | 936 ++++++++++++++++++
 6 files changed, 1039 insertions(+), 46 deletions(-)
 delete mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-ad4130
 create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7779.yaml
 create mode 100644 drivers/iio/adc/ad7779.c

Comments

Jonathan Cameron June 23, 2024, 12:43 p.m. UTC | #1
Don't change the patch title of a series mid way through multiple revisions
without a very good reason. Some of the automation we use relies on those
matching to ensure the latest version is picked up.

J