| Message ID | 20240518204443.122586-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindings: soc: hisilicon: document hi3660-usb3-otg-bc | expand |
On Sat, May 18, 2024 at 10:44:42PM +0200, Krzysztof Kozlowski wrote: > Add dedicated bindings for the Hisilicon Kirin 960 USB OTG Syscon, > to fully document the block and also fix dtbs_check warning: > hi3660-hikey960.dtb: usb3_otg_bc@ff200000: compatible: ['syscon', 'simple-mfd'] is too short > +title: Hisilicon Kirin 960 USB OTG Syscon > + - const: hisilicon,hi3660-usb3-otg-bc I know you got it from the node name, what does "bc" mean here? Otherwise, Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Hi Conor, On 2024/5/21 1:10, Conor Dooley wrote: > On Sat, May 18, 2024 at 10:44:42PM +0200, Krzysztof Kozlowski wrote: >> Add dedicated bindings for the Hisilicon Kirin 960 USB OTG Syscon, >> to fully document the block and also fix dtbs_check warning: > >> hi3660-hikey960.dtb: usb3_otg_bc@ff200000: compatible: ['syscon', 'simple-mfd'] is too short > >> +title: Hisilicon Kirin 960 USB OTG Syscon >> + - const: hisilicon,hi3660-usb3-otg-bc > > I know you got it from the node name, what does "bc" mean here? I think it might be the USB Battery Charging Specification. Best Regards, Wei > Otherwise, > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> >
On Sat, 18 May 2024 22:44:42 +0200, Krzysztof Kozlowski wrote: > Add dedicated bindings for the Hisilicon Kirin 960 USB OTG Syscon, > to fully document the block and also fix dtbs_check warning: > > hi3660-hikey960.dtb: usb3_otg_bc@ff200000: compatible: ['syscon', 'simple-mfd'] is too short > > One month waiting, so I'll take this one as well. Applied, thanks! [1/2] dt-bindings: soc: hisilicon: document hi3660-usb3-otg-bc https://git.kernel.org/krzk/linux-dt/c/7613195d37d69ff92c9bc55599037615212ce19c [2/2] arm64: dts: hisilicon: hi3660: add dedicated hi3660-usb3-otg-bc compatible https://git.kernel.org/krzk/linux-dt/c/bc9ec165d066af29661ece91f9cbf74e18ec0a5a Best regards,
Hi Krzysztof, On 2024/6/23 20:27, Krzysztof Kozlowski wrote: > > On Sat, 18 May 2024 22:44:42 +0200, Krzysztof Kozlowski wrote: >> Add dedicated bindings for the Hisilicon Kirin 960 USB OTG Syscon, >> to fully document the block and also fix dtbs_check warning: >> >> hi3660-hikey960.dtb: usb3_otg_bc@ff200000: compatible: ['syscon', 'simple-mfd'] is too short >> >> > > One month waiting, so I'll take this one as well. > > Applied, thanks! Fine to me. Thanks! Best Regards, Wei > > [1/2] dt-bindings: soc: hisilicon: document hi3660-usb3-otg-bc > https://git.kernel.org/krzk/linux-dt/c/7613195d37d69ff92c9bc55599037615212ce19c > [2/2] arm64: dts: hisilicon: hi3660: add dedicated hi3660-usb3-otg-bc compatible > https://git.kernel.org/krzk/linux-dt/c/bc9ec165d066af29661ece91f9cbf74e18ec0a5a > > Best regards, >
diff --git a/Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hi3660-usb3-otg-bc.yaml b/Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hi3660-usb3-otg-bc.yaml new file mode 100644 index 000000000000..2e26637a4711 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hi3660-usb3-otg-bc.yaml @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/hisilicon/hisilicon,hi3660-usb3-otg-bc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Hisilicon Kirin 960 USB OTG Syscon + +maintainers: + - Mauro Carvalho Chehab <mchehab+huawei@kernel.org> + +properties: + compatible: + items: + - const: hisilicon,hi3660-usb3-otg-bc + - const: syscon + - const: simple-mfd + + reg: + maxItems: 1 + + usb-phy: + $ref: /schemas/phy/hisilicon,hi3660-usb3.yaml + description: USB Phy node + +required: + - compatible + - reg + - usb-phy + +additionalProperties: false + +examples: + - | + syscon@ff200000 { + compatible = "hisilicon,hi3660-usb3-otg-bc", "syscon", "simple-mfd"; + reg = <0xff200000 0x1000>; + + usb-phy { + compatible = "hisilicon,hi3660-usb-phy"; + #phy-cells = <0>; + hisilicon,pericrg-syscon = <&crg_ctrl>; + hisilicon,pctrl-syscon = <&pctrl>; + hisilicon,eye-diagram-param = <0x22466e4>; + }; + };
Add dedicated bindings for the Hisilicon Kirin 960 USB OTG Syscon, to fully document the block and also fix dtbs_check warning: hi3660-hikey960.dtb: usb3_otg_bc@ff200000: compatible: ['syscon', 'simple-mfd'] is too short Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Cc: Jiaxun Yang <jiaxun.yang@flygoat.com> --- .../hisilicon,hi3660-usb3-otg-bc.yaml | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hi3660-usb3-otg-bc.yaml