mbox series

[for-4.19,v3,0/4] x86/shadow: Trace fixes and cleanup

Message ID 20240621180658.92831-1-andrew.cooper3@citrix.com (mailing list archive)
Headers show
Series x86/shadow: Trace fixes and cleanup | expand

Message

Andrew Cooper June 21, 2024, 6:06 p.m. UTC 
Patches 1-3 were my review feedback to Jan's patch 4.

For 4.19.  Patch 4 (the bugfix) was Release-Acked after I posted the series
(cleanup and rebased bugfix), which suggests your happy for it in principle,
but I can't treat that as an implict release ack on the whole series.

It's a tracing fix, so is minimal risk to the 4.19 release.

v3:
 * Retain __packed attribute.

Andrew Cooper (3):
  x86/shadow: Rework trace_shadow_gen() into sh_trace_va()
  x86/shadow: Introduce sh_trace_gl1e_va()
  x86/shadow: Rework trace_shadow_emulate_other() as sh_trace_gfn_va()

Jan Beulich (1):
  x86/shadow: Don't leave trace record field uninitialized

 xen/arch/x86/mm/shadow/multi.c | 144 ++++++++++++++-------------------
 1 file changed, 60 insertions(+), 84 deletions(-)


base-commit: 9e7c26ad8532c3efda174dee5ab8bdbeef1e4f6d

Comments

Oleksii Kurochko June 24, 2024, 8:11 a.m. UTC | #1 
On Fri, 2024-06-21 at 19:06 +0100, Andrew Cooper wrote:
> Patches 1-3 were my review feedback to Jan's patch 4.
> 
> For 4.19.  Patch 4 (the bugfix) was Release-Acked after I posted the
> series
> (cleanup and rebased bugfix), which suggests your happy for it in
> principle,
> but I can't treat that as an implict release ack on the whole series.
> 
> It's a tracing fix, so is minimal risk to the 4.19 release.
Sorry for confusion, first patches don't provide any functional
changes, so it is okay to me to have it in Release 4.19.

So for the whole patch series:
 Release-Acked-By: Oleksii Kurochko <oleksii.kurochko@gmail.com>

~ Oleksii
> 
> v3:
>  * Retain __packed attribute.
> 
> Andrew Cooper (3):
>   x86/shadow: Rework trace_shadow_gen() into sh_trace_va()
>   x86/shadow: Introduce sh_trace_gl1e_va()
>   x86/shadow: Rework trace_shadow_emulate_other() as
> sh_trace_gfn_va()
> 
> Jan Beulich (1):
>   x86/shadow: Don't leave trace record field uninitialized
> 
>  xen/arch/x86/mm/shadow/multi.c | 144 ++++++++++++++-----------------
> --
>  1 file changed, 60 insertions(+), 84 deletions(-)
> 
> 
> base-commit: 9e7c26ad8532c3efda174dee5ab8bdbeef1e4f6d