| Message ID | 20240602-md-clk-imx-v1-1-5c6d240f6fab@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | clk: imx: add missing MODULE_DESCRIPTION() macros | expand |
On 6/2/2024 8:59 AM, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/clk/imx/mxc-clk.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/clk/imx/clk-imxrt1050.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > drivers/clk/imx/clk-imxrt1050.c | 1 + > drivers/clk/imx/clk.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c > index 08d155feb035..efd1ac9d8eeb 100644 > --- a/drivers/clk/imx/clk-imxrt1050.c > +++ b/drivers/clk/imx/clk-imxrt1050.c > @@ -176,6 +176,7 @@ static struct platform_driver imxrt1050_clk_driver = { > }; > module_platform_driver(imxrt1050_clk_driver); > > +MODULE_DESCRIPTION("NXP i.MX RT1050 clock driver"); > MODULE_LICENSE("Dual BSD/GPL"); > MODULE_AUTHOR("Jesse Taube <Mr.Bossman075@gmail.com>"); > MODULE_AUTHOR("Giulio Benetti <giulio.benetti@benettiengineering.com>"); > diff --git a/drivers/clk/imx/clk.c b/drivers/clk/imx/clk.c > index e35496af5ceb..df83bd939492 100644 > --- a/drivers/clk/imx/clk.c > +++ b/drivers/clk/imx/clk.c > @@ -226,4 +226,5 @@ static int __init imx_clk_disable_uart(void) > late_initcall_sync(imx_clk_disable_uart); > #endif > > +MODULE_DESCRIPTION("Common clock support for NXP i.MX SoC family"); > MODULE_LICENSE("GPL v2"); > > --- > base-commit: 83814698cf48ce3aadc5d88a3f577f04482ff92a > change-id: 20240602-md-clk-imx-370fc1d85ab5 > Following up to see if anything else is needed from me. Hoping to see this in linux-next :)
On 24-06-02 08:59:17, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/clk/imx/mxc-clk.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/clk/imx/clk-imxrt1050.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> Reviewed-by: Abel Vesa <abel.vesa@linaro.org> > --- > drivers/clk/imx/clk-imxrt1050.c | 1 + > drivers/clk/imx/clk.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c > index 08d155feb035..efd1ac9d8eeb 100644 > --- a/drivers/clk/imx/clk-imxrt1050.c > +++ b/drivers/clk/imx/clk-imxrt1050.c > @@ -176,6 +176,7 @@ static struct platform_driver imxrt1050_clk_driver = { > }; > module_platform_driver(imxrt1050_clk_driver); > > +MODULE_DESCRIPTION("NXP i.MX RT1050 clock driver"); > MODULE_LICENSE("Dual BSD/GPL"); > MODULE_AUTHOR("Jesse Taube <Mr.Bossman075@gmail.com>"); > MODULE_AUTHOR("Giulio Benetti <giulio.benetti@benettiengineering.com>"); > diff --git a/drivers/clk/imx/clk.c b/drivers/clk/imx/clk.c > index e35496af5ceb..df83bd939492 100644 > --- a/drivers/clk/imx/clk.c > +++ b/drivers/clk/imx/clk.c > @@ -226,4 +226,5 @@ static int __init imx_clk_disable_uart(void) > late_initcall_sync(imx_clk_disable_uart); > #endif > > +MODULE_DESCRIPTION("Common clock support for NXP i.MX SoC family"); > MODULE_LICENSE("GPL v2"); > > --- > base-commit: 83814698cf48ce3aadc5d88a3f577f04482ff92a > change-id: 20240602-md-clk-imx-370fc1d85ab5 >
On Sun, 02 Jun 2024 08:59:17 -0700, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/clk/imx/mxc-clk.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/clk/imx/clk-imxrt1050.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > > [...] Applied, thanks! [1/1] clk: imx: add missing MODULE_DESCRIPTION() macros commit: 1919d77a9591aa692c8de11540ffc0e7d18eabb4 Best regards,
On 6/24/2024 6:05 AM, Abel Vesa wrote: > > On Sun, 02 Jun 2024 08:59:17 -0700, Jeff Johnson wrote: >> make allmodconfig && make W=1 C=1 reports: >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/clk/imx/mxc-clk.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/clk/imx/clk-imxrt1050.o >> >> Add the missing invocations of the MODULE_DESCRIPTION() macro. >> >> >> [...] > > Applied, thanks! > > [1/1] clk: imx: add missing MODULE_DESCRIPTION() macros > commit: 1919d77a9591aa692c8de11540ffc0e7d18eabb4 Hi Abel, I see this landed in linux-next, but is not currently in Linus' tree for 6.11. Will you be able to have this pulled during the merge window? I'm trying to eradicate all of these warnings before 6.11 rc-final. Thanks! /jeff
diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c index 08d155feb035..efd1ac9d8eeb 100644 --- a/drivers/clk/imx/clk-imxrt1050.c +++ b/drivers/clk/imx/clk-imxrt1050.c @@ -176,6 +176,7 @@ static struct platform_driver imxrt1050_clk_driver = { }; module_platform_driver(imxrt1050_clk_driver); +MODULE_DESCRIPTION("NXP i.MX RT1050 clock driver"); MODULE_LICENSE("Dual BSD/GPL"); MODULE_AUTHOR("Jesse Taube <Mr.Bossman075@gmail.com>"); MODULE_AUTHOR("Giulio Benetti <giulio.benetti@benettiengineering.com>"); diff --git a/drivers/clk/imx/clk.c b/drivers/clk/imx/clk.c index e35496af5ceb..df83bd939492 100644 --- a/drivers/clk/imx/clk.c +++ b/drivers/clk/imx/clk.c @@ -226,4 +226,5 @@ static int __init imx_clk_disable_uart(void) late_initcall_sync(imx_clk_disable_uart); #endif +MODULE_DESCRIPTION("Common clock support for NXP i.MX SoC family"); MODULE_LICENSE("GPL v2");
make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/clk/imx/mxc-clk.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/clk/imx/clk-imxrt1050.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- drivers/clk/imx/clk-imxrt1050.c | 1 + drivers/clk/imx/clk.c | 1 + 2 files changed, 2 insertions(+) --- base-commit: 83814698cf48ce3aadc5d88a3f577f04482ff92a change-id: 20240602-md-clk-imx-370fc1d85ab5