diff mbox series

[rdma-next] RDMA/mlx4: Fix truncated output warning in mad.c

Message ID f3798b3ce9a410257d7e1ec7c9e285f1352e256a.1718554569.git.leon@kernel.org (mailing list archive)
State Accepted
Headers show
Series [rdma-next] RDMA/mlx4: Fix truncated output warning in mad.c | expand

Commit Message

Leon Romanovsky June 16, 2024, 4:16 p.m. UTC 
From: Leon Romanovsky <leonro@nvidia.com>

Increase size of the name array to avoid truncated output warning.

drivers/infiniband/hw/mlx4/mad.c: In function ‘mlx4_ib_alloc_demux_ctx’:
drivers/infiniband/hw/mlx4/mad.c:2197:47: error: ‘%d’ directive output
may be truncated writing between 1 and 11 bytes into a region of size 4
[-Werror=format-truncation=]
 2197 |         snprintf(name, sizeof(name), "mlx4_ibt%d", port);
      |                                               ^~
drivers/infiniband/hw/mlx4/mad.c:2197:38: note: directive argument in
the range [-2147483645, 2147483647]
 2197 |         snprintf(name, sizeof(name), "mlx4_ibt%d", port);
      |                                      ^~~~~~~~~~~~
drivers/infiniband/hw/mlx4/mad.c:2197:9: note: ‘snprintf’ output between
10 and 20 bytes into a destination of size 12
 2197 |         snprintf(name, sizeof(name), "mlx4_ibt%d", port);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/infiniband/hw/mlx4/mad.c:2205:48: error: ‘%d’ directive output
may be truncated writing between 1 and 11 bytes into a region of size 3
[-Werror=format-truncation=]
 2205 |         snprintf(name, sizeof(name), "mlx4_ibwi%d", port);
      |                                                ^~
drivers/infiniband/hw/mlx4/mad.c:2205:38: note: directive argument in
the range [-2147483645, 2147483647]
 2205 |         snprintf(name, sizeof(name), "mlx4_ibwi%d", port);
      |                                      ^~~~~~~~~~~~~
drivers/infiniband/hw/mlx4/mad.c:2205:9: note: ‘snprintf’ output between
11 and 21 bytes into a destination of size 12
 2205 |         snprintf(name, sizeof(name), "mlx4_ibwi%d", port);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/infiniband/hw/mlx4/mad.c:2213:48: error: ‘%d’ directive output
may be truncated writing between 1 and 11 bytes into a region of size 3
[-Werror=format-truncation=]
 2213 |         snprintf(name, sizeof(name), "mlx4_ibud%d", port);
      |                                                ^~
drivers/infiniband/hw/mlx4/mad.c:2213:38: note: directive argument in
the range [-2147483645, 2147483647]
 2213 |         snprintf(name, sizeof(name), "mlx4_ibud%d", port);
      |                                      ^~~~~~~~~~~~~
drivers/infiniband/hw/mlx4/mad.c:2213:9: note: ‘snprintf’ output between
11 and 21 bytes into a destination of size 12
 2213 |         snprintf(name, sizeof(name), "mlx4_ibud%d", port);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[6]: *** [scripts/Makefile.build:244: drivers/infiniband/hw/mlx4/mad.o] Error 1

Fixes: fc06573dfaf8 ("IB/mlx4: Initialize SR-IOV IB support for slaves in master context")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
 drivers/infiniband/hw/mlx4/mad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Leon Romanovsky June 24, 2024, 9:51 a.m. UTC | #1 
On Sun, 16 Jun 2024 19:16:33 +0300, Leon Romanovsky wrote:
> Increase size of the name array to avoid truncated output warning.
> 
> drivers/infiniband/hw/mlx4/mad.c: In function ‘mlx4_ib_alloc_demux_ctx’:
> drivers/infiniband/hw/mlx4/mad.c:2197:47: error: ‘%d’ directive output
> may be truncated writing between 1 and 11 bytes into a region of size 4
> [-Werror=format-truncation=]
>  2197 |         snprintf(name, sizeof(name), "mlx4_ibt%d", port);
>       |                                               ^~
> drivers/infiniband/hw/mlx4/mad.c:2197:38: note: directive argument in
> the range [-2147483645, 2147483647]
>  2197 |         snprintf(name, sizeof(name), "mlx4_ibt%d", port);
>       |                                      ^~~~~~~~~~~~
> drivers/infiniband/hw/mlx4/mad.c:2197:9: note: ‘snprintf’ output between
> 10 and 20 bytes into a destination of size 12
>  2197 |         snprintf(name, sizeof(name), "mlx4_ibt%d", port);
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/infiniband/hw/mlx4/mad.c:2205:48: error: ‘%d’ directive output
> may be truncated writing between 1 and 11 bytes into a region of size 3
> [-Werror=format-truncation=]
>  2205 |         snprintf(name, sizeof(name), "mlx4_ibwi%d", port);
>       |                                                ^~
> drivers/infiniband/hw/mlx4/mad.c:2205:38: note: directive argument in
> the range [-2147483645, 2147483647]
>  2205 |         snprintf(name, sizeof(name), "mlx4_ibwi%d", port);
>       |                                      ^~~~~~~~~~~~~
> drivers/infiniband/hw/mlx4/mad.c:2205:9: note: ‘snprintf’ output between
> 11 and 21 bytes into a destination of size 12
>  2205 |         snprintf(name, sizeof(name), "mlx4_ibwi%d", port);
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/infiniband/hw/mlx4/mad.c:2213:48: error: ‘%d’ directive output
> may be truncated writing between 1 and 11 bytes into a region of size 3
> [-Werror=format-truncation=]
>  2213 |         snprintf(name, sizeof(name), "mlx4_ibud%d", port);
>       |                                                ^~
> drivers/infiniband/hw/mlx4/mad.c:2213:38: note: directive argument in
> the range [-2147483645, 2147483647]
>  2213 |         snprintf(name, sizeof(name), "mlx4_ibud%d", port);
>       |                                      ^~~~~~~~~~~~~
> drivers/infiniband/hw/mlx4/mad.c:2213:9: note: ‘snprintf’ output between
> 11 and 21 bytes into a destination of size 12
>  2213 |         snprintf(name, sizeof(name), "mlx4_ibud%d", port);
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[6]: *** [scripts/Makefile.build:244: drivers/infiniband/hw/mlx4/mad.o] Error 1
> 
> [...]

Applied, thanks!

[1/1] RDMA/mlx4: Fix truncated output warning in mad.c
      https://git.kernel.org/rdma/rdma/c/01c6d9f59148b6

Best regards,
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c
index a37cfac5e23f..dc9cf45d2d32 100644
--- a/drivers/infiniband/hw/mlx4/mad.c
+++ b/drivers/infiniband/hw/mlx4/mad.c
@@ -2158,7 +2158,7 @@  static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev,
 				       struct mlx4_ib_demux_ctx *ctx,
 				       int port)
 {
-	char name[12];
+	char name[21];
 	int ret = 0;
 	int i;