| Message ID | e0fa98f138a7b2836128178f8b3a757978517307.1718897545.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: tmio: Remove obsolete callbacks | expand |
On Thu, 20 Jun 2024, Geert Uytterhoeven wrote: > Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last > user of the .set_clk_div() callback in the tmio_mmc_data structure. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > include/linux/mfd/tmio.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h > index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644 > --- a/include/linux/mfd/tmio.h > +++ b/include/linux/mfd/tmio.h > @@ -101,7 +101,6 @@ struct tmio_mmc_data { > unsigned int max_blk_count; > unsigned short max_segs; > void (*set_pwr)(struct platform_device *host, int state); > - void (*set_clk_div)(struct platform_device *host, int state); Any ramifications for just hoovering this up?
On Thu, Jun 20, 2024 at 05:39:45PM GMT, Geert Uytterhoeven wrote: > Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last > user of the .set_clk_div() callback in the tmio_mmc_data structure. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On Thu, Jun 20, 2024 at 10:05:44PM GMT, Wolfram Sang wrote: > On Thu, Jun 20, 2024 at 05:39:45PM GMT, Geert Uytterhoeven wrote: > > Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last > > user of the .set_clk_div() callback in the tmio_mmc_data structure. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Also: Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On Thu, Jun 20, 2024 at 4:40 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last > user of the .set_clk_div() callback in the tmio_mmc_data structure. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > include/linux/mfd/tmio.h | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Cheers, Prabhakar > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h > index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644 > --- a/include/linux/mfd/tmio.h > +++ b/include/linux/mfd/tmio.h > @@ -101,7 +101,6 @@ struct tmio_mmc_data { > unsigned int max_blk_count; > unsigned short max_segs; > void (*set_pwr)(struct platform_device *host, int state); > - void (*set_clk_div)(struct platform_device *host, int state); > }; > > /* > -- > 2.34.1 > >
Hi Lee, On Thu, Jun 20, 2024 at 7:08 PM Lee Jones <lee@kernel.org> wrote: > On Thu, 20 Jun 2024, Geert Uytterhoeven wrote: > > Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last > > user of the .set_clk_div() callback in the tmio_mmc_data structure. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > include/linux/mfd/tmio.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h > > index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644 > > --- a/include/linux/mfd/tmio.h > > +++ b/include/linux/mfd/tmio.h > > @@ -101,7 +101,6 @@ struct tmio_mmc_data { > > unsigned int max_blk_count; > > unsigned short max_segs; > > void (*set_pwr)(struct platform_device *host, int state); > > - void (*set_clk_div)(struct platform_device *host, int state); > > Any ramifications for just hoovering this up? I am sorry, I am not familiar with that expression. Can you please elaborate? Thanks! Gr{oetje,eeting}s, Geert
On Mon, 24 Jun 2024, Geert Uytterhoeven wrote: > Hi Lee, > > On Thu, Jun 20, 2024 at 7:08 PM Lee Jones <lee@kernel.org> wrote: > > On Thu, 20 Jun 2024, Geert Uytterhoeven wrote: > > > Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last > > > user of the .set_clk_div() callback in the tmio_mmc_data structure. > > > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- > > > include/linux/mfd/tmio.h | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h > > > index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644 > > > --- a/include/linux/mfd/tmio.h > > > +++ b/include/linux/mfd/tmio.h > > > @@ -101,7 +101,6 @@ struct tmio_mmc_data { > > > unsigned int max_blk_count; > > > unsigned short max_segs; > > > void (*set_pwr)(struct platform_device *host, int state); > > > - void (*set_clk_div)(struct platform_device *host, int state); > > > > Any ramifications for just hoovering this up? > > I am sorry, I am not familiar with that expression. > Can you please elaborate? > Thanks! If I take _only_ this patch and leave the MMC one, will something break?
Hi Lee, On Mon, Jun 24, 2024 at 12:46 PM Lee Jones <lee@kernel.org> wrote: > On Mon, 24 Jun 2024, Geert Uytterhoeven wrote: > > On Thu, Jun 20, 2024 at 7:08 PM Lee Jones <lee@kernel.org> wrote: > > > On Thu, 20 Jun 2024, Geert Uytterhoeven wrote: > > > > Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last > > > > user of the .set_clk_div() callback in the tmio_mmc_data structure. > > > > > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > --- > > > > include/linux/mfd/tmio.h | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h > > > > index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644 > > > > --- a/include/linux/mfd/tmio.h > > > > +++ b/include/linux/mfd/tmio.h > > > > @@ -101,7 +101,6 @@ struct tmio_mmc_data { > > > > unsigned int max_blk_count; > > > > unsigned short max_segs; > > > > void (*set_pwr)(struct platform_device *host, int state); > > > > - void (*set_clk_div)(struct platform_device *host, int state); > > > > > > Any ramifications for just hoovering this up? > > > > I am sorry, I am not familiar with that expression. > > Can you please elaborate? > > Thanks! > > If I take _only_ this patch and leave the MMC one, will something break? No, nothing will break. It will just (a) make it a tad more difficult to apply the second patch to the MMC tree, as it has a contextual dependency on the first patch, and (b) cause a merge conflict for linux-next and Linus later... Perhaps it would be easier to just provide an Acked-by, like you have already done for the second patch? Thanks! Gr{oetje,eeting}s, Geert
On Mon, 24 Jun 2024, Geert Uytterhoeven wrote: > Hi Lee, > > On Mon, Jun 24, 2024 at 12:46 PM Lee Jones <lee@kernel.org> wrote: > > On Mon, 24 Jun 2024, Geert Uytterhoeven wrote: > > > On Thu, Jun 20, 2024 at 7:08 PM Lee Jones <lee@kernel.org> wrote: > > > > On Thu, 20 Jun 2024, Geert Uytterhoeven wrote: > > > > > Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last > > > > > user of the .set_clk_div() callback in the tmio_mmc_data structure. > > > > > > > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > --- > > > > > include/linux/mfd/tmio.h | 1 - > > > > > 1 file changed, 1 deletion(-) > > > > > > > > > > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h > > > > > index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644 > > > > > --- a/include/linux/mfd/tmio.h > > > > > +++ b/include/linux/mfd/tmio.h > > > > > @@ -101,7 +101,6 @@ struct tmio_mmc_data { > > > > > unsigned int max_blk_count; > > > > > unsigned short max_segs; > > > > > void (*set_pwr)(struct platform_device *host, int state); > > > > > - void (*set_clk_div)(struct platform_device *host, int state); > > > > > > > > Any ramifications for just hoovering this up? > > > > > > I am sorry, I am not familiar with that expression. > > > Can you please elaborate? > > > Thanks! > > > > If I take _only_ this patch and leave the MMC one, will something break? > > No, nothing will break. > > It will just (a) make it a tad more difficult to apply the second patch > to the MMC tree, as it has a contextual dependency on the first patch, > and (b) cause a merge conflict for linux-next and Linus later... > Perhaps it would be easier to just provide an Acked-by, like you have > already done for the second patch? Considering this is only a one-liner, this should be okay. Acked-by: Lee Jones <lee@kernel.org>
diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644 --- a/include/linux/mfd/tmio.h +++ b/include/linux/mfd/tmio.h @@ -101,7 +101,6 @@ struct tmio_mmc_data { unsigned int max_blk_count; unsigned short max_segs; void (*set_pwr)(struct platform_device *host, int state); - void (*set_clk_div)(struct platform_device *host, int state); }; /*
Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last user of the .set_clk_div() callback in the tmio_mmc_data structure. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- include/linux/mfd/tmio.h | 1 - 1 file changed, 1 deletion(-)