| Message ID | 20240618131342.103995-4-quic_nainmeht@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add MPSS remoteproc support for SDX75 | expand |
On 6/18/24 15:13, Naina Mehta wrote: > Rename qdss@88800000 memory region as qlink_logging memory region > and add qdss_mem memory region at address of 0x88500000. > Split mpss_dsmharq_mem region into 2 separate regions and > reduce the size of mpssadsp_mem region. > > Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com> > --- Alright, we're getting somewhere. The commit message should however motivate why such changes are necessary. For all we know, the splitting in two is currently done for no reason, as qdss_mem and qlink_logging_mem are contiguous - does the firmware have some expectations about them being separate? Konrad
On 6/18/2024 7:08 PM, Konrad Dybcio wrote: > > > On 6/18/24 15:13, Naina Mehta wrote: >> Rename qdss@88800000 memory region as qlink_logging memory region >> and add qdss_mem memory region at address of 0x88500000. >> Split mpss_dsmharq_mem region into 2 separate regions and >> reduce the size of mpssadsp_mem region. >> >> Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com> >> --- > > Alright, we're getting somewhere. The commit message should however > motivate > why such changes are necessary. For all we know, the splitting in two is > currently done for no reason, as qdss_mem and qlink_logging_mem are > contiguous > - does the firmware have some expectations about them being separate? > Since different DSM region size is required for different modem firmware, mpss_dsmharq_mem region being split into 2 separate regions. This would provide the flexibility to remove the region which is not required for a particular platform. qlink_logging is being added at the memory region at the address of 0x88800000 as the region is being used by modem firmware. Regards, Naina > Konrad
On 24.06.2024 1:21 PM, Naina Mehta wrote: > > > On 6/18/2024 7:08 PM, Konrad Dybcio wrote: >> >> >> On 6/18/24 15:13, Naina Mehta wrote: >>> Rename qdss@88800000 memory region as qlink_logging memory region >>> and add qdss_mem memory region at address of 0x88500000. >>> Split mpss_dsmharq_mem region into 2 separate regions and >>> reduce the size of mpssadsp_mem region. >>> >>> Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com> >>> --- >> >> Alright, we're getting somewhere. The commit message should however motivate >> why such changes are necessary. For all we know, the splitting in two is >> currently done for no reason, as qdss_mem and qlink_logging_mem are contiguous >> - does the firmware have some expectations about them being separate? >> > > Since different DSM region size is required for different modem firmware, mpss_dsmharq_mem region being split into 2 separate regions. > This would provide the flexibility to remove the region which is > not required for a particular platform. > qlink_logging is being added at the memory region at the address of > 0x88800000 as the region is being used by modem firmware. Ok, now put that in the commit message :) And I suppose: "This would provide the flexibility to remove the region which is not required for a particular platform." - but you still pass both to the remoteproc in patch 4. Are these regions mutually exclusive? Konrad
On 6/26/2024 9:12 PM, Konrad Dybcio wrote: > On 24.06.2024 1:21 PM, Naina Mehta wrote: >> >> >> On 6/18/2024 7:08 PM, Konrad Dybcio wrote: >>> >>> >>> On 6/18/24 15:13, Naina Mehta wrote: >>>> Rename qdss@88800000 memory region as qlink_logging memory region >>>> and add qdss_mem memory region at address of 0x88500000. >>>> Split mpss_dsmharq_mem region into 2 separate regions and >>>> reduce the size of mpssadsp_mem region. >>>> >>>> Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com> >>>> --- >>> >>> Alright, we're getting somewhere. The commit message should however motivate >>> why such changes are necessary. For all we know, the splitting in two is >>> currently done for no reason, as qdss_mem and qlink_logging_mem are contiguous >>> - does the firmware have some expectations about them being separate? >>> >> >> Since different DSM region size is required for different modem firmware, mpss_dsmharq_mem region being split into 2 separate regions. >> This would provide the flexibility to remove the region which is >> not required for a particular platform. >> qlink_logging is being added at the memory region at the address of >> 0x88800000 as the region is being used by modem firmware. > > Ok, now put that in the commit message :) > > And I suppose: > > "This would provide the flexibility to remove the region which is not > required for a particular platform." - but you still pass both to the > remoteproc in patch 4. Are these regions mutually exclusive? > Yes, for IDP platform, we are using both the DSM regions. Based on the modem firmware either both the regions have to be used or only mpss_dsm_mem has to be used. Regards, Naina > Konrad >
diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi index 9b93f6501d55..6f0abcc87a3b 100644 --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi @@ -366,7 +366,12 @@ uefi_log_mem: uefi-log@87f75000 { no-map; }; - qdss_mem: qdss@88800000 { + qdss_mem: qdss@88500000 { + reg = <0x0 0x88500000 0x0 0x300000>; + no-map; + }; + + qlink_logging_mem: qlink-logging@88800000 { reg = <0x0 0x88800000 0x0 0x300000>; no-map; }; @@ -377,8 +382,13 @@ audio_heap_mem: audio-heap@88b00000 { no-map; }; - mpss_dsmharq_mem: mpss-dsmharq@88f00000 { - reg = <0x0 0x88f00000 0x0 0x5080000>; + mpss_dsm_mem_2: mpss-dsm-2@88f00000 { + reg = <0x0 0x88f00000 0x0 0x2500000>; + no-map; + }; + + mpss_dsm_mem: mpss-dsm@8b400000 { + reg = <0x0 0x8b400000 0x0 0x2b80000>; no-map; }; @@ -388,7 +398,7 @@ q6_mpss_dtb_mem: q6-mpss-dtb@8df80000 { }; mpssadsp_mem: mpssadsp@8e000000 { - reg = <0x0 0x8e000000 0x0 0xf400000>; + reg = <0x0 0x8e000000 0x0 0xf100000>; no-map; };
Rename qdss@88800000 memory region as qlink_logging memory region and add qdss_mem memory region at address of 0x88500000. Split mpss_dsmharq_mem region into 2 separate regions and reduce the size of mpssadsp_mem region. Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com> --- arch/arm64/boot/dts/qcom/sdx75.dtsi | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-)