| Message ID | 20240624103638.2087821-2-sumang@marvell.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | octeontx2-af: Fix klockwork issues in AF driver | expand |
> Fix minor klockwork issue in CGX. These are not real issues but sanity checks. Please improve your change descriptions considerably. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc4#n45 … > +++ b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c > @@ -465,6 +465,13 @@ u64 cgx_lmac_addr_get(u8 cgx_id, u8 lmac_id) > u64 cfg; > int id; > > + if (!cgx_dev) > + return 0; > + > + lmac = lmac_pdata(lmac_id, cgx_dev); > + if (!lmac) > + return 0; > + > mac_ops = cgx_dev->mac_ops; > > id = get_sequence_id_of_lmac(cgx_dev, lmac_id); > @@ -1648,7 +1655,7 @@ unsigned long cgx_get_lmac_bmap(void *cgxd) > static int cgx_lmac_init(struct cgx *cgx) > { > struct lmac *lmac; > - u64 lmac_list; > + u64 lmac_list = 0; > int i, err; > > /* lmac_list specifies which lmacs are enabled Did you mix software development concern categories here? Please reconsider your selection of change combinations once more. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc4#n168 Regards, Markus
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c index 27935c54b91b..af42a6d23e53 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c @@ -465,6 +465,13 @@ u64 cgx_lmac_addr_get(u8 cgx_id, u8 lmac_id) u64 cfg; int id; + if (!cgx_dev) + return 0; + + lmac = lmac_pdata(lmac_id, cgx_dev); + if (!lmac) + return 0; + mac_ops = cgx_dev->mac_ops; id = get_sequence_id_of_lmac(cgx_dev, lmac_id); @@ -1648,7 +1655,7 @@ unsigned long cgx_get_lmac_bmap(void *cgxd) static int cgx_lmac_init(struct cgx *cgx) { struct lmac *lmac; - u64 lmac_list; + u64 lmac_list = 0; int i, err; /* lmac_list specifies which lmacs are enabled
Fix minor klockwork issue in CGX. These are not real issues but sanity checks. Fixes: 96be2e0da85e ("octeontx2-af: Support for MAC address filters in CGX") Signed-off-by: Suman Ghosh <sumang@marvell.com> --- drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)