| Message ID | e26de71af72b51abd425f2e75f30d794e0ba46a2.1719218291.git.federico.serafini@bugseng.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | x86: address some violations of MISRA C Rule 16.3 | expand |
On 24.06.2024 11:04, Federico Serafini wrote: > --- a/xen/arch/x86/hvm/vpt.c > +++ b/xen/arch/x86/hvm/vpt.c > @@ -121,6 +121,8 @@ static int pt_irq_masked(struct periodic_time *pt) > } > > /* Fallthrough to check if the interrupt is masked on the IO APIC. */ > + fallthrough; > + > case PTSRC_ioapic: > { > int mask = vioapic_get_mask(v->domain, gsi); I'm afraid this is one more case where the (pseudo)keyword wants indenting by one more level, to match others relative to the case labels. Sure, this will be a little odd with the preceding figure brace, but what do you do? Jan
On Mon, 24 Jun 2024, Federico Serafini wrote: > Add pseudo keyword fallthrough to meet the requirements to deviate > a violation of MISRA C Rule 16.3 ("An unconditional `break' > statement shall terminate every switch-clause"). > > No functional change. > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index e1d6845a28..c76a9a272b 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -121,6 +121,8 @@ static int pt_irq_masked(struct periodic_time *pt) } /* Fallthrough to check if the interrupt is masked on the IO APIC. */ + fallthrough; + case PTSRC_ioapic: { int mask = vioapic_get_mask(v->domain, gsi);
Add pseudo keyword fallthrough to meet the requirements to deviate a violation of MISRA C Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause"). No functional change. Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> --- xen/arch/x86/hvm/vpt.c | 2 ++ 1 file changed, 2 insertions(+)