| Message ID | 20240623023329.1044-3-naoki@radxa.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] arm64: dts: rockchip: add SFC support for Radxa ROCK 5B | expand |
Hi, > SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency. I don't think a fixes tag is needed, because there is no documentation for this. See also (sfc part): https://lore.kernel.org/lkml/d7de2213-8dd2-42ec-9a30-a569ac71be3e@kwiboo.se/ > > Fixes: ee219017ddb5 ("arm64: dts: rockchip: Add Radxa ROCK 3C") > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> Thanks, Chukun
Hi, Thank you very much for your comment! On 6/23/24 13:04, Chukun Pan wrote: > Hi, >> SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency. > > I don't think a fixes tag is needed, because there is no documentation > for this. See also (sfc part): > https://lore.kernel.org/lkml/d7de2213-8dd2-42ec-9a30-a569ac71be3e@kwiboo.se/ I see, I'll remove fixes tag in v2. btw, is this change reasonable(acceptable)? Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. >> >> Fixes: ee219017ddb5 ("arm64: dts: rockchip: Add Radxa ROCK 3C") >> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > > Thanks, > Chukun >
Hi, > I see, I'll remove fixes tag in v2. > btw, is this change reasonable(acceptable)? I think there's no problem and it's acceptable. It would be better if you could give examples of flash chips that might be used. Thanks, Chukun
Am Sonntag, 23. Juni 2024, 06:24:56 CEST schrieb FUKAUMI Naoki: > Hi, > > Thank you very much for your comment! > > On 6/23/24 13:04, Chukun Pan wrote: > > Hi, > >> SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency. > > > > I don't think a fixes tag is needed, because there is no documentation > > for this. See also (sfc part): > > https://lore.kernel.org/lkml/d7de2213-8dd2-42ec-9a30-a569ac71be3e@kwiboo.se/ > > I see, I'll remove fixes tag in v2. > btw, is this change reasonable(acceptable)? it is, also no need to resend, I just dropped the Fixes tag myself
Hi, On 6/24/24 19:00, Chukun Pan wrote: > Hi, >> I see, I'll remove fixes tag in v2. >> btw, is this change reasonable(acceptable)? > > I think there's no problem and it's acceptable. It would be better > if you could give examples of flash chips that might be used. here is a list of my board: ROCK 5A: MXIC (SPI flash module, no schematic) ROCK 5B: MXIC (XTX in schematic) ROCK 3A: MXIC (Winbond in schematic) ROCK 3B: MXIC (Winbond in schematic) ROCK 3C: GigaDevice (same as schematic) Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. > Thanks, > Chukun >
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts index b242409d378c..f2cc086e5001 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts @@ -633,7 +633,7 @@ &sfc { flash@0 { compatible = "jedec,spi-nor"; reg = <0x0>; - spi-max-frequency = <120000000>; + spi-max-frequency = <104000000>; spi-rx-bus-width = <4>; spi-tx-bus-width = <1>; };
SPI NOR flash chip may vary, so use safe(lowest) spi-max-frequency. Fixes: ee219017ddb5 ("arm64: dts: rockchip: Add Radxa ROCK 3C") Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> --- arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)