| Message ID | 20240624211858.1990601-1-chris.packham@alliedtelesis.co.nz (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c0c68e4d52ed7fdecec7dab05cd5b8540ce4813e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 25/06/2024 00.18, Chris Packham wrote: > Update the mt7530 binding with some minor updates that make the document > easier to read. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > > Notes: > I was referring to this dt binding and found a couple of places where > the wording could be improved. I'm not exactly a techical writer but > hopefully I've made things a bit better. > > Changes in v2: > - Update title, this is not just fixing grammar > - Add missing The instead of changing has to have Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> Arınç
On 24/06/2024 22:18, Chris Packham wrote: > Update the mt7530 binding with some minor updates that make the document > easier to read. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
On Tue, Jun 25, 2024 at 09:18:57AM +1200, Chris Packham wrote: > Update the mt7530 binding with some minor updates that make the document > easier to read. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
On Tue, Jun 25, 2024 at 09:18:57AM +1200, Chris Packham wrote: > Update the mt7530 binding with some minor updates that make the document > easier to read. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > > Notes: > I was referring to this dt binding and found a couple of places where > the wording could be improved. I'm not exactly a techical writer but > hopefully I've made things a bit better. > > Changes in v2: > - Update title, this is not just fixing grammar > - Add missing The instead of changing has to have > I don't really want to ack this, a 4th ack for some wording that has no impact on the binding itself just seems so utterly silly to me... Instead I've spent more time writing how silly I think it is than hitting the ack macro would take :)
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 25 Jun 2024 09:18:57 +1200 you wrote: > Update the mt7530 binding with some minor updates that make the document > easier to read. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > > Notes: > I was referring to this dt binding and found a couple of places where > the wording could be improved. I'm not exactly a techical writer but > hopefully I've made things a bit better. > > [...] Here is the summary with links: - [v2] dt-bindings: net: dsa: mediatek,mt7530: Minor wording fixes https://git.kernel.org/netdev/net-next/c/c0c68e4d52ed You are awesome, thank you!
On 25/06/2024 18:00, Conor Dooley wrote: > On Tue, Jun 25, 2024 at 09:18:57AM +1200, Chris Packham wrote: >> Update the mt7530 binding with some minor updates that make the document >> easier to read. >> >> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> >> --- >> >> Notes: >> I was referring to this dt binding and found a couple of places where >> the wording could be improved. I'm not exactly a techical writer but >> hopefully I've made things a bit better. >> >> Changes in v2: >> - Update title, this is not just fixing grammar >> - Add missing The instead of changing has to have >> > > I don't really want to ack this, a 4th ack for some wording that has > no impact on the binding itself just seems so utterly silly to me... > Instead I've spent more time writing how silly I think it is than > hitting the ack macro would take :) But look how many reviews/acks it got :). If you acked this, the patch would have like 4 tags! If only complex patches get so much attention... :) Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml index 1c2444121e60..7e405ad96eb2 100644 --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml @@ -22,16 +22,16 @@ description: | The MT7988 SoC comes with a built-in switch similar to MT7531 as well as four Gigabit Ethernet PHYs. The switch registers are directly mapped into the SoC's - memory map rather than using MDIO. The switch got an internally connected 10G + memory map rather than using MDIO. The switch has an internally connected 10G CPU port and 4 user ports connected to the built-in Gigabit Ethernet PHYs. - MT7530 in MT7620AN, MT7620DA, MT7620DAN and MT7620NN SoCs has got 10/100 PHYs + The MT7530 in MT7620AN, MT7620DA, MT7620DAN and MT7620NN SoCs has 10/100 PHYs and the switch registers are directly mapped into SoC's memory map rather than using MDIO. The DSA driver currently doesn't support MT7620 variants. There is only the standalone version of MT7531. - Port 5 on MT7530 has got various ways of configuration: + Port 5 on MT7530 supports various configurations: - Port 5 can be used as a CPU port.
Update the mt7530 binding with some minor updates that make the document easier to read. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- Notes: I was referring to this dt binding and found a couple of places where the wording could be improved. I'm not exactly a techical writer but hopefully I've made things a bit better. Changes in v2: - Update title, this is not just fixing grammar - Add missing The instead of changing has to have .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)