| Message ID | 20240625145017.1003346-2-jbrunet@baylibre.com (mailing list archive) |
|---|---|
| State | Under Review |
| Headers | show |
| Series | arm64: dts: amlogic: add power domain to hdmitx | expand |
On Tue, Jun 25, 2024 at 04:50:14PM +0200, Jerome Brunet wrote: > All Amlogic instances of the Synopsys HDMI controller need a power domain > enabled. This is currently missing because the Amlogic HDMI driver directly > pokes the power domain controller registers, which it should not do. > > Instead The HDMI controller should use the power controller. > Fix the bindings accordingly. > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Acked-by: Conor Dooley <conor.dooley@microchip.com>
diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml index 0c85894648d8..84d68b8cfccc 100644 --- a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml +++ b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml @@ -71,6 +71,10 @@ properties: - const: iahb - const: venci + power-domains: + maxItems: 1 + description: phandle to the associated power domain + resets: minItems: 3 @@ -129,6 +133,7 @@ examples: reset-names = "hdmitx_apb", "hdmitx", "hdmitx_phy"; clocks = <&clk_isfr>, <&clk_iahb>, <&clk_venci>; clock-names = "isfr", "iahb", "venci"; + power-domains = <&pd_vpu>; #address-cells = <1>; #size-cells = <0>;
All Amlogic instances of the Synopsys HDMI controller need a power domain enabled. This is currently missing because the Amlogic HDMI driver directly pokes the power domain controller registers, which it should not do. Instead The HDMI controller should use the power controller. Fix the bindings accordingly. Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> --- .../devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml | 5 +++++ 1 file changed, 5 insertions(+)