[net-next,v4,0/8] net: Add generic support for netdev LEDs

Message

Andrew Lunn April 6, 2024, 8:13 p.m. UTC

For some devices, the MAC controls the LEDs in the RJ45 connector, not
the PHY. This patchset provides generic support for such LEDs, and
adds the first user, mv88e6xxx.

The common code netdev_leds_setup() is passed a DT node containing the
LEDs and a structure of operations to act on the LEDs. The core will
then create an cdev LED for each LED found in the device tree node.

The callbacks are passed the netdev, and the index of the LED. In
order to make use of this within DSA, helpers are added to convert a
netdev to a ds and port.

The mv88e6xxx has been extended to add basic support for the 6352
LEDs. Only software control is added, but the API supports hardware
offload which can be added to the mv88e6xxx driver later.

For testing and demonstration, the Linksys Mamba aka. wrt1900ac has
the needed DT nodes added to describe its LEDs.

Signed-off-by: Andrew Lunn <[e-mail]>
---
Changes in v4:
- Fix leak of OF nodes
- Switch -> switch
- Replace patch with Vladimirs 3 patches.
- Drop new helpers, use dsa_port_from_netdev()
- One list head per netdev/port, not shared
- Drop usage of devm_led_classdev_register_ext() which might be unsafe.
- Link to v3: https://lore.kernel.org/r/[e-mail]

Changes in v3:
- Change Internet port LED from LED_FUNCTION_LAN to LED_FUNCTION_WAN
- Another attempt to get Kconfig correct
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- Validate maximum number of LEDs in core code
- Change Kconfig due to 0-day reports
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Andrew Lunn (5):
      net: Add helpers for netdev LEDs
      net: dsa: mv88e6xxx: Add helpers for 6352 LED blink and brightness
      net: dsa: mv88e6xxx: Tie the low level LED functions to device ops
      dsa: mv88e6xxx: Create port/netdev LEDs
      arm: boot: dts: mvebu: linksys-mamba: Add Ethernet LEDs

Vladimir Oltean (3):
      net: dsa: consolidate setup and teardown for shared ports
      net: dsa: break out port setup and teardown code per port type
      net: dsa: move call to driver port_setup after creation of netdev

 .../boot/dts/marvell/armada-xp-linksys-mamba.dts   |  53 ++++++
 drivers/net/dsa/mv88e6xxx/Kconfig                  |   1 +
 drivers/net/dsa/mv88e6xxx/chip.c                   | 127 ++++++++++++-
 drivers/net/dsa/mv88e6xxx/chip.h                   |  20 +++
 drivers/net/dsa/mv88e6xxx/port.c                   |  93 ++++++++++
 drivers/net/dsa/mv88e6xxx/port.h                   |  76 +++++++-
 include/net/netdev_leds.h                          |  50 ++++++
 net/Kconfig                                        |  11 ++
 net/core/Makefile                                  |   1 +
 net/core/netdev-leds.c                             | 199 +++++++++++++++++++++
 net/dsa/devlink.c                                  |  17 +-
 net/dsa/dsa.c                                      | 177 ++++++++++++------
 12 files changed, 752 insertions(+), 73 deletions(-)
---
base-commit: 3b4cf29bdab08328dfab5bb7b41a62937ea5b379
change-id: 20240316-v6-8-0-net-next-mv88e6xxx-leds-v4-ab77d73d52a4

Best regards,

Comments

Vladimir Oltean June 26, 2024, 12:16 p.m. UTC | #1

Hi Andrew,

On Sat, Apr 06, 2024 at 03:13:27PM -0500, Andrew Lunn wrote:
> For some devices, the MAC controls the LEDs in the RJ45 connector, not
> the PHY. This patchset provides generic support for such LEDs, and
> adds the first user, mv88e6xxx.
> 
> The common code netdev_leds_setup() is passed a DT node containing the
> LEDs and a structure of operations to act on the LEDs. The core will
> then create an cdev LED for each LED found in the device tree node.
> 
> The callbacks are passed the netdev, and the index of the LED. In
> order to make use of this within DSA, helpers are added to convert a
> netdev to a ds and port.
> 
> The mv88e6xxx has been extended to add basic support for the 6352
> LEDs. Only software control is added, but the API supports hardware
> offload which can be added to the mv88e6xxx driver later.
> 
> For testing and demonstration, the Linksys Mamba aka. wrt1900ac has
> the needed DT nodes added to describe its LEDs.
> 
> Signed-off-by: Andrew Lunn <[e-mail]>
> ---

I stumbled across a circumstance today where it would have been useful
if the netdev on user ports was created at ds->ops->port_setup() time.
It is something that this series accomplishes, but I think it got stuck
here. Do you plan to resend it, or is there any blocking issue?