| Message ID | 20240625-qcom-audio-wsa-second-speaker-v1-0-f65ffdfc368c@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: codecs: lpass-wsa-macro: Add support for newer v2.5 version | expand |
On Tue, Jun 25, 2024 at 06:58:44PM GMT, Krzysztof Kozlowski wrote: > Hi, > > LPASS codec v2.5 and newer have differences in registers which we did > not implement so far. Lack of proper support is visible during > playback: on SoCs with v2.6 (e.g. Qualcomm SM8550) only one speaker > plays. > > Add missing bits for v2.5 and newer codecs. > > This is similar work to already merged: > https://lore.kernel.org/all/20240612-lpass-codec-v25-v4-0-f63d3676dbc4@linaro.org/ > > No dependencies. I didn't check the register values, but the approach look sane Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Tue, 25 Jun 2024 18:58:44 +0200, Krzysztof Kozlowski wrote: > LPASS codec v2.5 and newer have differences in registers which we did > not implement so far. Lack of proper support is visible during > playback: on SoCs with v2.6 (e.g. Qualcomm SM8550) only one speaker > plays. > > Add missing bits for v2.5 and newer codecs. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/3] ASoC: codecs: lpass-wsa-macro: Drop unused define commit: 04f4de6f68eec73595682f32952467591f0cc016 [2/3] ASoC: codecs: lpass-wsa-macro: Prepare to accommodate new codec versions commit: 5dcf442bbbcada62631f5a376c44ff794596c2f0 [3/3] ASoC: codecs: lpass-wsa-macro: Correct support for newer v2.5 version commit: 727de4fbc5466c7150482b532f2b7f7e514134f3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Hi, LPASS codec v2.5 and newer have differences in registers which we did not implement so far. Lack of proper support is visible during playback: on SoCs with v2.6 (e.g. Qualcomm SM8550) only one speaker plays. Add missing bits for v2.5 and newer codecs. This is similar work to already merged: https://lore.kernel.org/all/20240612-lpass-codec-v25-v4-0-f63d3676dbc4@linaro.org/ No dependencies. Best regards, Krzysztof --- Krzysztof Kozlowski (3): ASoC: codecs: lpass-wsa-macro: Drop unused define ASoC: codecs: lpass-wsa-macro: Prepare to accommodate new codec versions ASoC: codecs: lpass-wsa-macro: Correct support for newer v2.5 version sound/soc/codecs/lpass-wsa-macro.c | 644 ++++++++++++++++++++++++++++++------- 1 file changed, 521 insertions(+), 123 deletions(-) --- base-commit: d585065ee5b64c60496a2403bafee1540cb319ec change-id: 20240625-qcom-audio-wsa-second-speaker-ee1a5d2d267b Best regards,