| Message ID | 20240607-md-drivers-cxl-v2-1-0c61d95ee7a7@quicinc.com |
|---|---|
| State | Accepted |
| Commit | a0caa19711ceb54c34368f66a746844fb03fde6c |
| Headers | show |
| Series | [v2] cxl: add missing MODULE_DESCRIPTION() macros | expand |
On Fri, 7 Jun 2024 06:57:15 -0700 Jeff Johnson <quic_jjohnson@quicinc.com> wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/core/cxl_core.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_pci.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_mem.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_acpi.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_pmem.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_port.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Thanks,
On 6/7/2024 7:10 AM, Jonathan Cameron wrote: > On Fri, 7 Jun 2024 06:57:15 -0700 > Jeff Johnson <quic_jjohnson@quicinc.com> wrote: > >> make allmodconfig && make W=1 C=1 reports: >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/core/cxl_core.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_pci.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_mem.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_acpi.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_pmem.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_port.o >> >> Add the missing invocations of the MODULE_DESCRIPTION() macro. >> >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Thanks, Following up to see if anything else is needed from me. Hoping to see this in linux-next so I can remove it from my tracking spreadsheet :) /jeff
On 6/26/24 9:02 AM, Jeff Johnson wrote: > On 6/7/2024 7:10 AM, Jonathan Cameron wrote: >> On Fri, 7 Jun 2024 06:57:15 -0700 >> Jeff Johnson <quic_jjohnson@quicinc.com> wrote: >> >>> make allmodconfig && make W=1 C=1 reports: >>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/core/cxl_core.o >>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_pci.o >>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_mem.o >>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_acpi.o >>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_pmem.o >>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_port.o >>> >>> Add the missing invocations of the MODULE_DESCRIPTION() macro. >>> >>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> >> >> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> >> >> Thanks, > > Following up to see if anything else is needed from me. Hoping to see this in > linux-next so I can remove it from my tracking spreadsheet :) I have it locally queued, but will probably push to linux-next after rc6 drops. > > /jeff
On 6/26/2024 9:41 AM, Dave Jiang wrote: > On 6/26/24 9:02 AM, Jeff Johnson wrote: >> Following up to see if anything else is needed from me. Hoping to see this in >> linux-next so I can remove it from my tracking spreadsheet :) > > I have it locally queued, but will probably push to linux-next after rc6 drops. thanks for the update! /jeff
On 6/26/2024 9:41 AM, Dave Jiang wrote: > > > On 6/26/24 9:02 AM, Jeff Johnson wrote: >> On 6/7/2024 7:10 AM, Jonathan Cameron wrote: >>> On Fri, 7 Jun 2024 06:57:15 -0700 >>> Jeff Johnson <quic_jjohnson@quicinc.com> wrote: >>> >>>> make allmodconfig && make W=1 C=1 reports: >>>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/core/cxl_core.o >>>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_pci.o >>>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_mem.o >>>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_acpi.o >>>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_pmem.o >>>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_port.o >>>> >>>> Add the missing invocations of the MODULE_DESCRIPTION() macro. >>>> >>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> >>> >>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> >>> >>> Thanks, >> >> Following up to see if anything else is needed from me. Hoping to see this in >> linux-next so I can remove it from my tracking spreadsheet :) > > I have it locally queued, but will probably push to linux-next after rc6 drops. Hi Dave, I see this landed in linux-next, but is not currently in Linus' tree for 6.11. Will you be able to have this pulled during the merge window? I'm trying to eradicate all of these warnings before 6.11 rc-final. Thanks! /jeff
Jeff Johnson wrote: > On 6/26/2024 9:41 AM, Dave Jiang wrote: > > > > > > On 6/26/24 9:02 AM, Jeff Johnson wrote: > >> On 6/7/2024 7:10 AM, Jonathan Cameron wrote: > >>> On Fri, 7 Jun 2024 06:57:15 -0700 > >>> Jeff Johnson <quic_jjohnson@quicinc.com> wrote: > >>> > >>>> make allmodconfig && make W=1 C=1 reports: > >>>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/core/cxl_core.o > >>>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_pci.o > >>>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_mem.o > >>>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_acpi.o > >>>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_pmem.o > >>>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_port.o > >>>> > >>>> Add the missing invocations of the MODULE_DESCRIPTION() macro. > >>>> > >>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > >>> > >>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > >>> > >>> Thanks, > >> > >> Following up to see if anything else is needed from me. Hoping to see this in > >> linux-next so I can remove it from my tracking spreadsheet :) > > > > I have it locally queued, but will probably push to linux-next after rc6 drops. > > Hi Dave, > > I see this landed in linux-next, but is not currently in Linus' tree for 6.11. > Will you be able to have this pulled during the merge window? > I'm trying to eradicate all of these warnings before 6.11 rc-final. This landed yesterday. Ira
diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c index 571069863c62..e51315ea4a6a 100644 --- a/drivers/cxl/acpi.c +++ b/drivers/cxl/acpi.c @@ -921,6 +921,7 @@ static void __exit cxl_acpi_exit(void) /* load before dax_hmem sees 'Soft Reserved' CXL ranges */ subsys_initcall(cxl_acpi_init); module_exit(cxl_acpi_exit); +MODULE_DESCRIPTION("CXL ACPI: Platform Support"); MODULE_LICENSE("GPL v2"); MODULE_IMPORT_NS(CXL); MODULE_IMPORT_NS(ACPI); diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c index 887ed6e358fb..e31c5fcd9bf8 100644 --- a/drivers/cxl/core/port.c +++ b/drivers/cxl/core/port.c @@ -2356,5 +2356,6 @@ static void cxl_core_exit(void) subsys_initcall(cxl_core_init); module_exit(cxl_core_exit); +MODULE_DESCRIPTION("CXL: Core Compute Express Link support"); MODULE_LICENSE("GPL v2"); MODULE_IMPORT_NS(CXL); diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c index 0c79d9ce877c..1afb0e78082b 100644 --- a/drivers/cxl/mem.c +++ b/drivers/cxl/mem.c @@ -252,6 +252,7 @@ static struct cxl_driver cxl_mem_driver = { module_cxl_driver(cxl_mem_driver); +MODULE_DESCRIPTION("CXL: Memory Expansion"); MODULE_LICENSE("GPL v2"); MODULE_IMPORT_NS(CXL); MODULE_ALIAS_CXL(CXL_DEVICE_MEMORY_EXPANDER); diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c index e53646e9f2fb..4be35dc22202 100644 --- a/drivers/cxl/pci.c +++ b/drivers/cxl/pci.c @@ -1066,5 +1066,6 @@ static void __exit cxl_pci_driver_exit(void) module_init(cxl_pci_driver_init); module_exit(cxl_pci_driver_exit); +MODULE_DESCRIPTION("CXL: PCI manageability"); MODULE_LICENSE("GPL v2"); MODULE_IMPORT_NS(CXL); diff --git a/drivers/cxl/pmem.c b/drivers/cxl/pmem.c index 2ecdaee63021..4ef93da22335 100644 --- a/drivers/cxl/pmem.c +++ b/drivers/cxl/pmem.c @@ -453,6 +453,7 @@ static __exit void cxl_pmem_exit(void) cxl_driver_unregister(&cxl_nvdimm_bridge_driver); } +MODULE_DESCRIPTION("CXL PMEM: Persistent Memory Support"); MODULE_LICENSE("GPL v2"); module_init(cxl_pmem_init); module_exit(cxl_pmem_exit); diff --git a/drivers/cxl/port.c b/drivers/cxl/port.c index 97c21566677a..d7d5d982ce69 100644 --- a/drivers/cxl/port.c +++ b/drivers/cxl/port.c @@ -209,6 +209,7 @@ static struct cxl_driver cxl_port_driver = { }; module_cxl_driver(cxl_port_driver); +MODULE_DESCRIPTION("CXL: Port enumeration and services"); MODULE_LICENSE("GPL v2"); MODULE_IMPORT_NS(CXL); MODULE_ALIAS_CXL(CXL_DEVICE_PORT);
make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/core/cxl_core.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_pci.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_mem.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_acpi.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_pmem.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cxl/cxl_port.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- Changes in v2: - Updated the descriptions in drivers/cxl/core/port.c and drivers/cxl/pci.c per feedback from Jonathan. - Updated the description in drivers/cxl/port.c per feedback from Dan. - Link to v1: https://lore.kernel.org/r/20240603-md-drivers-cxl-v1-1-f2940f5c0836@quicinc.com --- drivers/cxl/acpi.c | 1 + drivers/cxl/core/port.c | 1 + drivers/cxl/mem.c | 1 + drivers/cxl/pci.c | 1 + drivers/cxl/pmem.c | 1 + drivers/cxl/port.c | 1 + 6 files changed, 6 insertions(+) --- base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586 change-id: 20240603-md-drivers-cxl-85ac807b9618