| Message ID | 20240626201234.2572964-1-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2a901623f0056ccdb64dbfd3d98f9072f704f065 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] tools: ynl: use display hints for formatting of scalar attrs | expand |
Jakub Kicinski <kuba@kernel.org> writes: > Use display hints for formatting scalar attrs. This is specifically > useful for formatting IPv4 addresses carried typically as u32. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> I don't know how scalars got missed out :shrug: Reviewed-by: Donald Hunter <donald.hunter@gmail.com> Thanks! > --- > CC: donald.hunter@gmail.com > CC: jiri@resnulli.us > --- > tools/net/ynl/lib/ynl.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py > index 35e666928119..d42c1d605969 100644 > --- a/tools/net/ynl/lib/ynl.py > +++ b/tools/net/ynl/lib/ynl.py > @@ -743,6 +743,8 @@ genl_family_name_to_id = None > decoded = attr.as_scalar(attr_spec['type'], attr_spec.byte_order) > if 'enum' in attr_spec: > decoded = self._decode_enum(decoded, attr_spec) > + elif attr_spec.display_hint: > + decoded = self._formatted_string(decoded, attr_spec.display_hint) > elif attr_spec["type"] == 'indexed-array': > decoded = self._decode_array_attr(attr, attr_spec) > elif attr_spec["type"] == 'bitfield32':
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 26 Jun 2024 13:12:34 -0700 you wrote: > Use display hints for formatting scalar attrs. This is specifically > useful for formatting IPv4 addresses carried typically as u32. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > CC: donald.hunter@gmail.com > CC: jiri@resnulli.us > > [...] Here is the summary with links: - [net-next] tools: ynl: use display hints for formatting of scalar attrs https://git.kernel.org/netdev/net-next/c/2a901623f005 You are awesome, thank you!
diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py index 35e666928119..d42c1d605969 100644 --- a/tools/net/ynl/lib/ynl.py +++ b/tools/net/ynl/lib/ynl.py @@ -743,6 +743,8 @@ genl_family_name_to_id = None decoded = attr.as_scalar(attr_spec['type'], attr_spec.byte_order) if 'enum' in attr_spec: decoded = self._decode_enum(decoded, attr_spec) + elif attr_spec.display_hint: + decoded = self._formatted_string(decoded, attr_spec.display_hint) elif attr_spec["type"] == 'indexed-array': decoded = self._decode_array_attr(attr, attr_spec) elif attr_spec["type"] == 'bitfield32':
Use display hints for formatting scalar attrs. This is specifically useful for formatting IPv4 addresses carried typically as u32. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: donald.hunter@gmail.com CC: jiri@resnulli.us --- tools/net/ynl/lib/ynl.py | 2 ++ 1 file changed, 2 insertions(+)