| Message ID | 20240626202533.2182846-8-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,01/13] arm64: dts: layerscape: rename node 'timer' as 'rtc' | expand |
On Wed, Jun 26, 2024 at 2:26 PM Frank Li <Frank.Li@nxp.com> wrote: > > Add #dma-cells for qdma to fix below warning. > dma-controller@8380000: '#dma-cells' is a required property > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 + > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 + > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 + > 3 files changed, 3 insertions(+) Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
On Thu, Jun 27, 2024 at 11:17 AM Rob Herring <robh@kernel.org> wrote: > > On Wed, Jun 26, 2024 at 2:26 PM Frank Li <Frank.Li@nxp.com> wrote: > > > > Add #dma-cells for qdma to fix below warning. > > dma-controller@8380000: '#dma-cells' is a required property > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 + > > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 + > > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 + > > 3 files changed, 3 insertions(+) > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> Except for the typo in the subject... Frank, while I appreciate the great number of reductions in DT warnings on FSL platforms you and others have been working on, your work is sloppy with issues you should find yourself. Rob
On Thu, Jun 27, 2024 at 11:22:57AM -0600, Rob Herring wrote: > On Thu, Jun 27, 2024 at 11:17 AM Rob Herring <robh@kernel.org> wrote: > > > > On Wed, Jun 26, 2024 at 2:26 PM Frank Li <Frank.Li@nxp.com> wrote: > > > > > > Add #dma-cells for qdma to fix below warning. > > > dma-controller@8380000: '#dma-cells' is a required property > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > --- > > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 + > > > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 + > > > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 + > > > 3 files changed, 3 insertions(+) > > > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > > Except for the typo in the subject... > > Frank, while I appreciate the great number of reductions in DT > warnings on FSL platforms you and others have been working on, your > work is sloppy with issues you should find yourself. I found the typo after I sent yesterday. I planned fix it after collect some comments. It was already in shawn's tree. I hope shawn can help fix it. Frank > > Rob
On Thu, Jun 27, 2024 at 02:27:29PM -0400, Frank Li wrote: > On Thu, Jun 27, 2024 at 11:22:57AM -0600, Rob Herring wrote: > > On Thu, Jun 27, 2024 at 11:17 AM Rob Herring <robh@kernel.org> wrote: > > > > > > On Wed, Jun 26, 2024 at 2:26 PM Frank Li <Frank.Li@nxp.com> wrote: > > > > > > > > Add #dma-cells for qdma to fix below warning. > > > > dma-controller@8380000: '#dma-cells' is a required property > > > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > > --- > > > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 + > > > > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 + > > > > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 + > > > > 3 files changed, 3 insertions(+) > > > > > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > > > > Except for the typo in the subject... > > > > Frank, while I appreciate the great number of reductions in DT > > warnings on FSL platforms you and others have been working on, your > > work is sloppy with issues you should find yourself. > > I found the typo after I sent yesterday. I planned fix it after collect > some comments. It was already in shawn's tree. I hope shawn can help fix > it. s/layerscaple/layerscape Fixed it up. Thanks for spotting it, Rob! Shawn
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi index 4188faa59368e..de92af774771d 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi @@ -828,6 +828,7 @@ qdma: dma-controller@8380000 { <GIC_SPI 254 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "qdma-error", "qdma-queue0", "qdma-queue1", "qdma-queue2", "qdma-queue3"; + #dma-cells = <1>; dma-channels = <8>; block-number = <1>; block-offset = <0x10000>; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi index caf765593547b..acf3eab61b626 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi @@ -974,6 +974,7 @@ qdma: dma-controller@8380000 { <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "qdma-error", "qdma-queue0", "qdma-queue1", "qdma-queue2", "qdma-queue3"; + #dma-cells = <1>; dma-channels = <8>; block-number = <1>; block-offset = <0x10000>; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi index 524b44f424272..801c5b77d608f 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi @@ -925,6 +925,7 @@ qdma: dma-controller@8380000 { <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "qdma-error", "qdma-queue0", "qdma-queue1", "qdma-queue2", "qdma-queue3"; + #dma-cells = <1>; dma-channels = <8>; block-number = <1>; block-offset = <0x10000>;
Add #dma-cells for qdma to fix below warning. dma-controller@8380000: '#dma-cells' is a required property Signed-off-by: Frank Li <Frank.Li@nxp.com> --- arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 + arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 + arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 + 3 files changed, 3 insertions(+)