| Message ID | 20240612-outfield-gummy-388a36d95100@spud (mailing list archive) |
|---|---|
| Headers | show |
| Series | PCI: microchip: support using either instance 1 or 2 | expand |
With the proviso of fixing the axi_/apb_ nit Acked-by: Daire McNamara <daire.mcnamara@microchip.com> On Wed, Jun 12, 2024 at 11:57:54AM +0100, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > The current driver and binding for PolarFire SoC's PCI controller assume > that the root port instance in use is instance 1. The second reg > property constitutes the region encompassing both "control" and "bridge" > registers for both instances. In the driver, a fixed offset is applied to > find the base addresses for instance 1's "control" and "bridge" > registers. The BeagleV Fire uses root port instance 2, so something must > be done so that software can differentiate. This series splits the > second reg property in two, with dedicated "control" and "bridge" > entries so that either instance can be used. > > Cheers, > Conor. > > v2: > - try the new reg format before the old one to avoid warnings in the > new case > - reword $subject for 2/2 > > CC: Daire McNamara <daire.mcnamara@microchip.com> > CC: Lorenzo Pieralisi <lpieralisi@kernel.org> > CC: Krzysztof Wilczyński <kw@linux.com> > CC: Rob Herring <robh@kernel.org> > CC: Bjorn Helgaas <bhelgaas@google.com> > CC: Krzysztof Kozlowski <krzk+dt@kernel.org> > CC: Conor Dooley <conor+dt@kernel.org> > CC: linux-pci@vger.kernel.org > CC: devicetree@vger.kernel.org > CC: linux-kernel@vger.kernel.org > CC: linux-riscv@lists.infradead.org > > Conor Dooley (2): > dt-bindings: PCI: microchip,pcie-host: fix reg properties > PCI: microchip: rework reg region handing to support using either > instance 1 or 2 > > .../bindings/pci/microchip,pcie-host.yaml | 10 +- > drivers/pci/controller/pcie-microchip-host.c | 155 +++++++++--------- > 2 files changed, 79 insertions(+), 86 deletions(-) > > -- > 2.43.0 > >
From: Conor Dooley <conor.dooley@microchip.com> The current driver and binding for PolarFire SoC's PCI controller assume that the root port instance in use is instance 1. The second reg property constitutes the region encompassing both "control" and "bridge" registers for both instances. In the driver, a fixed offset is applied to find the base addresses for instance 1's "control" and "bridge" registers. The BeagleV Fire uses root port instance 2, so something must be done so that software can differentiate. This series splits the second reg property in two, with dedicated "control" and "bridge" entries so that either instance can be used. Cheers, Conor. v2: - try the new reg format before the old one to avoid warnings in the new case - reword $subject for 2/2 CC: Daire McNamara <daire.mcnamara@microchip.com> CC: Lorenzo Pieralisi <lpieralisi@kernel.org> CC: Krzysztof Wilczyński <kw@linux.com> CC: Rob Herring <robh@kernel.org> CC: Bjorn Helgaas <bhelgaas@google.com> CC: Krzysztof Kozlowski <krzk+dt@kernel.org> CC: Conor Dooley <conor+dt@kernel.org> CC: linux-pci@vger.kernel.org CC: devicetree@vger.kernel.org CC: linux-kernel@vger.kernel.org CC: linux-riscv@lists.infradead.org Conor Dooley (2): dt-bindings: PCI: microchip,pcie-host: fix reg properties PCI: microchip: rework reg region handing to support using either instance 1 or 2 .../bindings/pci/microchip,pcie-host.yaml | 10 +- drivers/pci/controller/pcie-microchip-host.c | 155 +++++++++--------- 2 files changed, 79 insertions(+), 86 deletions(-)