mbox series

[v3,0/2] btrfs: fix __folio_put refcount errors

Message ID cover.1719930430.git.boris@bur.io (mailing list archive)
Headers show
Series btrfs: fix __folio_put refcount errors | expand

Message

Boris Burkov July 2, 2024, 2:31 p.m. UTC 
Switching from __free_page to __folio_put introduced a bug because
__free_page called put_page_testzero while __folio_put does not. Fix the
two affected callers by changing to folio_put which does call
put_folio_testzero.
--
Changelog:
v3:
- split up patches for backporting
v2:
- add second callsite

Boris Burkov (2):
  btrfs: fix __folio_put refcount in btrfs_do_encoded_write
  btrfs: fix __folio_put refcount in __alloc_dummy_extent_buffer

 fs/btrfs/extent_io.c | 2 +-
 fs/btrfs/inode.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Filipe Manana July 2, 2024, 2:41 p.m. UTC | #1 
On Tue, Jul 2, 2024 at 3:32 PM Boris Burkov <boris@bur.io> wrote:
>
> Switching from __free_page to __folio_put introduced a bug because
> __free_page called put_page_testzero while __folio_put does not. Fix the
> two affected callers by changing to folio_put which does call
> put_folio_testzero.
> --
> Changelog:
> v3:
> - split up patches for backporting
> v2:
> - add second callsite
>
> Boris Burkov (2):
>   btrfs: fix __folio_put refcount in btrfs_do_encoded_write
>   btrfs: fix __folio_put refcount in __alloc_dummy_extent_buffer
>
>  fs/btrfs/extent_io.c | 2 +-
>  fs/btrfs/inode.c     | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

For both patches:

Reviewed-by: Filipe Manana <fdmanana@suse.com>

Thanks.
>
> --
> 2.45.2
>
>
David Sterba July 2, 2024, 5:23 p.m. UTC | #2 
On Tue, Jul 02, 2024 at 07:31:12AM -0700, Boris Burkov wrote:
> Switching from __free_page to __folio_put introduced a bug because
> __free_page called put_page_testzero while __folio_put does not. Fix the
> two affected callers by changing to folio_put which does call
> put_folio_testzero.
> --
> Changelog:
> v3:
> - split up patches for backporting
> v2:
> - add second callsite
> 
> Boris Burkov (2):
>   btrfs: fix __folio_put refcount in btrfs_do_encoded_write
>   btrfs: fix __folio_put refcount in __alloc_dummy_extent_buffer

Reviewed-by: David Sterba <dsterba@suse.com>