| Message ID | 20240626-port-map-v2-0-6cc1c5608cdd@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: codecs: wsa88xx: add support for static port mapping. | expand |
On Thu, 27 Jun 2024 15:44:37 +0100, srinivas.kandagatla@linaro.org wrote: > Existing way of allocating soundwire master ports on Qualcommm platforms is > dynamic, and in linear order starting from 1 to MAX_PORTS. > This will work as long as soundwire device ports are 1:1 mapped > linearly. However on most Qcom SoCs like SM8550, SM8650, x1e80100, these > are NOT mapped in that order. > > The result of this is that only one speaker among the pair of speakers > is always silent, With recent changes for WSA codec to support codec > versions and along with these patches we are able to get all speakers > working on these SoCs. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/6] ASoC: dt-bindings: wsa883x: Document port mapping property commit: 49beb4d2e85634ec1e1c82d76461d9552676045d [2/6] ASoC: codecs: wsa883x: parse port-mapping information commit: 1cf3295bd108abbd7f128071ae9775fd18394ca9 [3/6] ASoC: dt-bindings: wsa8840: Document port mapping property commit: d47abee9fede21b19d5227061c5a8761ec1659fb [4/6] ASoC: codecs: wsa884x: parse port-mapping information commit: e1bc5c324bcca3acdbe817ccbf9aa7992d89479d All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Thu, 27 Jun 2024 15:44:37 +0100, srinivas.kandagatla@linaro.org wrote: > Existing way of allocating soundwire master ports on Qualcommm platforms is > dynamic, and in linear order starting from 1 to MAX_PORTS. > This will work as long as soundwire device ports are 1:1 mapped > linearly. However on most Qcom SoCs like SM8550, SM8650, x1e80100, these > are NOT mapped in that order. > > The result of this is that only one speaker among the pair of speakers > is always silent, With recent changes for WSA codec to support codec > versions and along with these patches we are able to get all speakers > working on these SoCs. > > [...] Applied, thanks! [5/6] arm64: dts: x1e80100-crd: fix wsa soundwire port mapping commit: d374fafd8972895eba01ebd69c993cc7d80c084b [6/6] arm64: dts: x1e80100-qcp: fix wsa soundwire port mapping commit: 6e229f9118438af09b4ac6a96313c32f33027e5a Best regards,
Existing way of allocating soundwire master ports on Qualcommm platforms is dynamic, and in linear order starting from 1 to MAX_PORTS. This will work as long as soundwire device ports are 1:1 mapped linearly. However on most Qcom SoCs like SM8550, SM8650, x1e80100, these are NOT mapped in that order. The result of this is that only one speaker among the pair of speakers is always silent, With recent changes for WSA codec to support codec versions and along with these patches we are able to get all speakers working on these SoCs. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- Changes in v2: - used dev_dbg instead of dev_info - Link to v1: https://lore.kernel.org/r/20240626-port-map-v1-0-bd8987d2b332@linaro.org --- Manikantan R (1): ASoC: dt-bindings: wsa883x: Document port mapping property Srinivas Kandagatla (5): ASoC: codecs: wsa883x: parse port-mapping information ASoC: dt-bindings: wsa8840: Document port mapping property ASoC: codecs: wsa884x: parse port-mapping information arm64: dts: x1e80100-crd: fix wsa soundwire port mapping arm64: dts: x1e80100-qcp: fix wsa soundwire port mapping Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml | 8 ++++++++ Documentation/devicetree/bindings/sound/qcom,wsa8840.yaml | 8 ++++++++ arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 4 ++++ arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 2 ++ sound/soc/codecs/wsa883x.c | 8 ++++++++ sound/soc/codecs/wsa884x.c | 8 ++++++++ 6 files changed, 38 insertions(+) --- base-commit: 9935be184a55dd84fc3275094f2df095491f6ea1 change-id: 20240626-port-map-ef50c3304d4a Best regards,