| Message ID | 20240702234008.19101-1-richard.weiyang@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] mm: use zonelist_zone() to get zone | expand |
On 03.07.24 01:40, Wei Yang wrote: > Instead of accessing zoneref->zone directly, use zonelist_zone() like > other places for consistency. > > No functional change. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > CC: Mike Rapoport (IBM) <rppt@kernel.org> > --- > include/linux/mmzone.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index cb7f265c2b96..a34a74f5b113 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -1690,7 +1690,7 @@ static inline struct zoneref *first_zones_zonelist(struct zonelist *zonelist, > zone = zonelist_zone(z)) > > #define for_next_zone_zonelist_nodemask(zone, z, highidx, nodemask) \ > - for (zone = z->zone; \ > + for (zone = zonelist_zone(z); \ > zone; \ > z = next_zones_zonelist(++z, highidx, nodemask), \ > zone = zonelist_zone(z)) Should we do the same in movable_only_nodes as well to be consistent in that file?
On Fri, Jul 05, 2024 at 11:03:03AM +0200, David Hildenbrand wrote: >On 03.07.24 01:40, Wei Yang wrote: >> Instead of accessing zoneref->zone directly, use zonelist_zone() like >> other places for consistency. >> >> No functional change. >> >> Signed-off-by: Wei Yang <richard.weiyang@gmail.com> >> CC: Mike Rapoport (IBM) <rppt@kernel.org> >> --- >> include/linux/mmzone.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h >> index cb7f265c2b96..a34a74f5b113 100644 >> --- a/include/linux/mmzone.h >> +++ b/include/linux/mmzone.h >> @@ -1690,7 +1690,7 @@ static inline struct zoneref *first_zones_zonelist(struct zonelist *zonelist, >> zone = zonelist_zone(z)) >> #define for_next_zone_zonelist_nodemask(zone, z, highidx, nodemask) \ >> - for (zone = z->zone; \ >> + for (zone = zonelist_zone(z); \ >> zone; \ >> z = next_zones_zonelist(++z, highidx, nodemask), \ >> zone = zonelist_zone(z)) > >Should we do the same in movable_only_nodes as well to be consistent in that >file? > Agree, thanks >-- >Cheers, > >David / dhildenb
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index cb7f265c2b96..a34a74f5b113 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -1690,7 +1690,7 @@ static inline struct zoneref *first_zones_zonelist(struct zonelist *zonelist, zone = zonelist_zone(z)) #define for_next_zone_zonelist_nodemask(zone, z, highidx, nodemask) \ - for (zone = z->zone; \ + for (zone = zonelist_zone(z); \ zone; \ z = next_zones_zonelist(++z, highidx, nodemask), \ zone = zonelist_zone(z))
Instead of accessing zoneref->zone directly, use zonelist_zone() like other places for consistency. No functional change. Signed-off-by: Wei Yang <richard.weiyang@gmail.com> CC: Mike Rapoport (IBM) <rppt@kernel.org> --- include/linux/mmzone.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)