| Message ID | 20240705084047.857176-24-alex.bennee@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | July maintainer updates (32bit, testing, plugins, gdbstub) | expand |
On Fri, 5 Jul 2024 at 11:57, Alex Bennée <alex.bennee@linaro.org> wrote: > > We can't assign sock_path directly from the autofree'd GStrv, take a > copy. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > contrib/plugins/lockstep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c > index 237543b43a..111ec3fa27 100644 > --- a/contrib/plugins/lockstep.c > +++ b/contrib/plugins/lockstep.c > @@ -347,7 +347,7 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_install(qemu_plugin_id_t id, > return -1; > } > } else if (g_strcmp0(tokens[0], "sockpath") == 0) { > - sock_path = tokens[1]; > + sock_path = strdup(tokens[1]); s/strdup/g_strdup ? Otherwise, Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> > } else { > fprintf(stderr, "option parsing failed: %s\n", p); > return -1; > -- > 2.39.2 > >
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index 237543b43a..111ec3fa27 100644 --- a/contrib/plugins/lockstep.c +++ b/contrib/plugins/lockstep.c @@ -347,7 +347,7 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_install(qemu_plugin_id_t id, return -1; } } else if (g_strcmp0(tokens[0], "sockpath") == 0) { - sock_path = tokens[1]; + sock_path = strdup(tokens[1]); } else { fprintf(stderr, "option parsing failed: %s\n", p); return -1;
We can't assign sock_path directly from the autofree'd GStrv, take a copy. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- contrib/plugins/lockstep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)