diff mbox series

[2/2] arm64: dts: armada-3720: align LED node name with bindings

Message ID 20240701150340.560243-2-krzysztof.kozlowski@linaro.org (mailing list archive)
State New, archived
Headers show
Series [1/2] arm64: dts: armada-3720: align GPIO keys node name with bindings | expand

Commit Message

Krzysztof Kozlowski July 1, 2024, 3:03 p.m. UTC
Bindings expect the LED node names to follow certain pattern, see
dtbs_check warnings:

  armada-3720-gl-mv1000.dtb: leds: 'power', 'vpn', 'wan' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Gregory CLEMENT July 5, 2024, 12:49 p.m. UTC | #1
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:

> Bindings expect the LED node names to follow certain pattern, see
> dtbs_check warnings:
>
>   armada-3720-gl-mv1000.dtb: leds: 'power', 'vpn', 'wan' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied on mvebu/dt64

Thanks,

Gregory
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> index 07c14bf04b83..56930f2ce481 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> @@ -57,17 +57,17 @@ switch {
>  	leds {
>  		compatible = "gpio-leds";
>  
> -		vpn {
> +		led-vpn {
>  			label = "green:vpn";
>  			gpios = <&gpionb 11 GPIO_ACTIVE_LOW>;
>  		};
>  
> -		wan {
> +		led-wan {
>  			label = "green:wan";
>  			gpios = <&gpionb 12 GPIO_ACTIVE_LOW>;
>  		};
>  
> -		led_power: power {
> +		led_power: led-power {
>  			label = "green:power";
>  			gpios = <&gpionb 13 GPIO_ACTIVE_LOW>;
>  			default-state = "on";
> -- 
> 2.43.0
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
index 07c14bf04b83..56930f2ce481 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
@@ -57,17 +57,17 @@  switch {
 	leds {
 		compatible = "gpio-leds";
 
-		vpn {
+		led-vpn {
 			label = "green:vpn";
 			gpios = <&gpionb 11 GPIO_ACTIVE_LOW>;
 		};
 
-		wan {
+		led-wan {
 			label = "green:wan";
 			gpios = <&gpionb 12 GPIO_ACTIVE_LOW>;
 		};
 
-		led_power: power {
+		led_power: led-power {
 			label = "green:power";
 			gpios = <&gpionb 13 GPIO_ACTIVE_LOW>;
 			default-state = "on";