mbox series

[GSoC,0/5] t: port reftable/merged_test.c to the unit testing framework

Message ID 20240703171131.3929-1-chandrapratap3519@gmail.com (mailing list archive)
Headers show
Series t: port reftable/merged_test.c to the unit testing framework | expand

Message

Chandra Pratap July 3, 2024, 5:01 p.m. UTC
In the recent codebase update (commit 8bf6fbd, 2023-12-09), a new unit
testing framework written entirely in C was introduced to the Git project
aimed at simplifying testing and reducing test run times.
Currently, tests for the reftable refs-backend are performed by a custom
testing framework defined by reftable/test_framework.{c, h}. Port
reftable/merged_test.c to the unit testing framework and improve upon
the ported test.

The first patch in the series moves the test to the unit testing framework,
and the rest of the patches improve upon the ported test.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>

---
CI/PR: https://github.com/gitgitgadget/git/pull/1755

Chandra Pratap (5):
[PATCH 1/5] t: move reftable/merged_test.c to the unit testing framework
[PATCH 2/5] t: harmonize t-reftable-merged.c with coding guidelines
[PATCH 3/5] t-reftable-merged: add test for reftable_merged_table_max_update_index()
[PATCH 4/5] t-reftable-merged: use reftable_ref_record_equal to compare ref records
[PATCH 5/5] t-reftable-merged: add test for REFTABLE_FORMAT_ERROR

Makefile                                                   |   2 +-
t/helper/test-reftable.c                                   |   1 -
reftable/merged_test.c => t/unit-tests/t-reftable-merged.c | 170 +++++++++++++++----------------
3 files changed, 86 insertions(+), 87 deletions(-)

Comments

Karthik Nayak July 5, 2024, 6:24 p.m. UTC | #1
Chandra Pratap <chandrapratap3519@gmail.com> writes:

> In the recent codebase update (commit 8bf6fbd, 2023-12-09), a new unit
> testing framework written entirely in C was introduced to the Git project
> aimed at simplifying testing and reducing test run times.
> Currently, tests for the reftable refs-backend are performed by a custom
> testing framework defined by reftable/test_framework.{c, h}. Port
> reftable/merged_test.c to the unit testing framework and improve upon
> the ported test.
>
> The first patch in the series moves the test to the unit testing framework,
> and the rest of the patches improve upon the ported test.
>

I went through the commits and left some small comments. Looks great
already.

Thanks

[snip]