| Message ID | DM4P223MB054139F737887D40A2CA396FF7D92@DM4P223MB0541.NAMP223.PROD.OUTLOOK.COM (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] Removed extra asterisks from comment beginnings, and removed unnecessary comment end | expand |
Hi-- On 7/6/24 9:14 PM, Gold Side wrote: > From 33dc0aa3973913f310840cc8f7d5d599d573c297 Mon Sep 17 00:00:00 2001 > From: Steven Davis <goldside000@outlook.com> > Date: Tue, 2 Jul 2024 23:43:15 -0400 > Subject: [PATCH 2/3] Removed unnecessary comment end > > It still works the same without that comment end, so why is it in there? Building with clang should report a warning similar to this: error: '/*' within block comment [-Werror,-Wcomment] which is not acceptable. > Signed-off-by: Steven Davis <goldside000@outlook.com> > --- > include/memory/renesas-rpc-if.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/memory/renesas-rpc-if.h b/include/memory/renesas-rpc-if.h > index b8fa30fd6b500c..591dd86f55f879 100644 > --- a/include/memory/renesas-rpc-if.h > +++ b/include/memory/renesas-rpc-if.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +/* SPDX-License-Identifier: GPL-2.0 > /* > * Renesas RPC-IF core driver > * >
On 07/07/2024 06:14, Gold Side wrote: > From 33dc0aa3973913f310840cc8f7d5d599d573c297 Mon Sep 17 00:00:00 2001 > From: Steven Davis <goldside000@outlook.com> > Date: Tue, 2 Jul 2024 23:43:15 -0400 > Subject: [PATCH 2/3] Removed unnecessary comment end > > It still works the same without that comment end, so why is it in there? Because license-rules asks for it. Why do you change only one file? Look how this is done in other files. This should make you ask questions why doing things differently. > Signed-off-by: Steven Davis <goldside000@outlook.com> Please use git to create commits, not hand-craft them. Missing blank line before tag. Entire patch does not look like proper patch, but some weirdly generated mbox file. :/ Use git format-patch or b4. > --- > include/memory/renesas-rpc-if.h | 2 +- Best regards, Krzysztof
diff --git a/include/memory/renesas-rpc-if.h b/include/memory/renesas-rpc-if.h index b8fa30fd6b500c..591dd86f55f879 100644 --- a/include/memory/renesas-rpc-if.h +++ b/include/memory/renesas-rpc-if.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0 */ +/* SPDX-License-Identifier: GPL-2.0 /* * Renesas RPC-IF core driver *