| Message ID | 20240703160458.1303872-1-lyude@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/vkms: Remove event from vkms_output | expand |
Le 03/07/24 - 12:04, Lyude Paul a écrit : > While working on rvkms, I noticed that there's no code that actually uses > the drm_pending_vblank_event that's embedded in vkms_output. So, just drop > the member from the struct. This seems to be a leftover of the work on the introduction on vblank, if you look at the V1 [1] you can see it was used, but not removed on the last iteration [2]. It apply properly on drm-misc-next and igt test kms_flip/kms_vblank are success. [1]: https://lore.kernel.org/all/20180625171922.5ofev566kghxxxwu@smtp.gmail.com/ [2]: https://lore.kernel.org/all/5d9ca7b3884c1995bd4a983b1d2ff1b840eb7f1a.1531402095.git.rodrigosiqueiramelo@gmail.com/ Reviewed-By: Louis Chauvet <louis.chauvet@bootlin.com> Tested-By: Louis Chauvet <louis.chauvet@bootlin.com> > > Signed-off-by: Lyude Paul <lyude@redhat.com> > --- > drivers/gpu/drm/vkms/vkms_drv.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h > index 8f5710debb1eb..5e46ea5b96dcc 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.h > +++ b/drivers/gpu/drm/vkms/vkms_drv.h > @@ -103,7 +103,6 @@ struct vkms_output { > struct drm_writeback_connector wb_connector; > struct hrtimer vblank_hrtimer; > ktime_t period_ns; > - struct drm_pending_vblank_event *event; > /* ordered wq for composer_work */ > struct workqueue_struct *composer_workq; > /* protects concurrent access to composer */ > -- > 2.45.2 >
On 7/3/24 13:04, Lyude Paul wrote: > While working on rvkms, I noticed that there's no code that actually uses > the drm_pending_vblank_event that's embedded in vkms_output. So, just drop > the member from the struct. > > Signed-off-by: Lyude Paul <lyude@redhat.com> Reviewed-by: Maíra Canal <mcanal@igalia.com> Feel free to apply it to drm-misc/drm-misc-next! Otherwise, I'll apply it over the weekend. Best Regards, - Maíra > --- > drivers/gpu/drm/vkms/vkms_drv.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h > index 8f5710debb1eb..5e46ea5b96dcc 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.h > +++ b/drivers/gpu/drm/vkms/vkms_drv.h > @@ -103,7 +103,6 @@ struct vkms_output { > struct drm_writeback_connector wb_connector; > struct hrtimer vblank_hrtimer; > ktime_t period_ns; > - struct drm_pending_vblank_event *event; > /* ordered wq for composer_work */ > struct workqueue_struct *composer_workq; > /* protects concurrent access to composer */
On 7/3/24 13:04, Lyude Paul wrote: > While working on rvkms, I noticed that there's no code that actually uses > the drm_pending_vblank_event that's embedded in vkms_output. So, just drop > the member from the struct. > > Signed-off-by: Lyude Paul <lyude@redhat.com> Applied to drm-misc/drm-misc-next! Best Regards, - Maíra > --- > drivers/gpu/drm/vkms/vkms_drv.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h > index 8f5710debb1eb..5e46ea5b96dcc 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.h > +++ b/drivers/gpu/drm/vkms/vkms_drv.h > @@ -103,7 +103,6 @@ struct vkms_output { > struct drm_writeback_connector wb_connector; > struct hrtimer vblank_hrtimer; > ktime_t period_ns; > - struct drm_pending_vblank_event *event; > /* ordered wq for composer_work */ > struct workqueue_struct *composer_workq; > /* protects concurrent access to composer */
diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h index 8f5710debb1eb..5e46ea5b96dcc 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.h +++ b/drivers/gpu/drm/vkms/vkms_drv.h @@ -103,7 +103,6 @@ struct vkms_output { struct drm_writeback_connector wb_connector; struct hrtimer vblank_hrtimer; ktime_t period_ns; - struct drm_pending_vblank_event *event; /* ordered wq for composer_work */ struct workqueue_struct *composer_workq; /* protects concurrent access to composer */
While working on rvkms, I noticed that there's no code that actually uses the drm_pending_vblank_event that's embedded in vkms_output. So, just drop the member from the struct. Signed-off-by: Lyude Paul <lyude@redhat.com> --- drivers/gpu/drm/vkms/vkms_drv.h | 1 - 1 file changed, 1 deletion(-)