| Message ID | 20240703025850.2172008-2-quic_tengfan@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | arm64: qcom: dts: add QCS9100 support | expand |
On 03/07/2024 04:58, Tengfei Fan wrote: > Document the QCS9100 SoC and RIDE board. > > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index ec1c10a12470..f06543f96026 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -45,6 +45,7 @@ description: | > qcs8550 > qcm2290 > qcm6490 > + qcs9100 > qdu1000 > qrb2210 > qrb4210 > @@ -894,7 +895,9 @@ properties: > > - items: > - enum: > + - qcom,qcs9100-ride > - qcom,sa8775p-ride > + - const: qcom,qcs9100 This changes existing compatible for sa8775p without any explanation in commit msg. Best regards, Krzysztof
On 7/3/2024 12:38 PM, Krzysztof Kozlowski wrote: > On 03/07/2024 04:58, Tengfei Fan wrote: >> Document the QCS9100 SoC and RIDE board. >> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- >> Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >> index ec1c10a12470..f06543f96026 100644 >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >> @@ -45,6 +45,7 @@ description: | >> qcs8550 >> qcm2290 >> qcm6490 >> + qcs9100 >> qdu1000 >> qrb2210 >> qrb4210 >> @@ -894,7 +895,9 @@ properties: >> >> - items: >> - enum: >> + - qcom,qcs9100-ride >> - qcom,sa8775p-ride >> + - const: qcom,qcs9100 > > This changes existing compatible for sa8775p without any explanation in > commit msg. > > Best regards, > Krzysztof > In the next verion patch series, I will provide relevant explanatory information in this patch commit message.
On 03/07/2024 11:21, Tengfei Fan wrote: >>> - items: >>> - enum: >>> + - qcom,qcs9100-ride >>> - qcom,sa8775p-ride >>> + - const: qcom,qcs9100 >> >> This changes existing compatible for sa8775p without any explanation in >> commit msg. >> >> Best regards, >> Krzysztof >> > > In the next verion patch series, I will provide relevant explanatory > information in this patch commit message. TBH, I cannot think of any reasonable explanation for this, especially considering rest of the patchset which does not fix resulting dtbs_check warning. Best regards, Krzysztof
On 7/3/2024 5:33 PM, Krzysztof Kozlowski wrote: > On 03/07/2024 11:21, Tengfei Fan wrote: >>>> - items: >>>> - enum: >>>> + - qcom,qcs9100-ride >>>> - qcom,sa8775p-ride >>>> + - const: qcom,qcs9100 >>> >>> This changes existing compatible for sa8775p without any explanation in >>> commit msg. >>> >>> Best regards, >>> Krzysztof >>> >> >> In the next verion patch series, I will provide relevant explanatory >> information in this patch commit message. > > TBH, I cannot think of any reasonable explanation for this, especially > considering rest of the patchset which does not fix resulting dtbs_check > warning. > > Best regards, > Krzysztof > This patch may need to be updated based on the results of dtbs_check. In the new version patch series, I will revise the commit message according to the patch updates made.
On 7/3/2024 5:33 PM, Krzysztof Kozlowski wrote: > On 03/07/2024 11:21, Tengfei Fan wrote: >>>> - items: >>>> - enum: >>>> + - qcom,qcs9100-ride >>>> - qcom,sa8775p-ride >>>> + - const: qcom,qcs9100 >>> >>> This changes existing compatible for sa8775p without any explanation in >>> commit msg. >>> >>> Best regards, >>> Krzysztof >>> >> >> In the next verion patch series, I will provide relevant explanatory >> information in this patch commit message. > > TBH, I cannot think of any reasonable explanation for this, especially > considering rest of the patchset which does not fix resulting dtbs_check > warning. The existing compatible "sa8775p" warning can only be addressed When @Nikunj's "sa8775p" changes merged. Let me know if you have other suggestions for this. > > Best regards, > Krzysztof >
On 08/07/2024 06:45, Aiqun Yu (Maria) wrote: > > > On 7/3/2024 5:33 PM, Krzysztof Kozlowski wrote: >> On 03/07/2024 11:21, Tengfei Fan wrote: >>>>> - items: >>>>> - enum: >>>>> + - qcom,qcs9100-ride >>>>> - qcom,sa8775p-ride >>>>> + - const: qcom,qcs9100 >>>> >>>> This changes existing compatible for sa8775p without any explanation in >>>> commit msg. >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> >>> In the next verion patch series, I will provide relevant explanatory >>> information in this patch commit message. >> >> TBH, I cannot think of any reasonable explanation for this, especially >> considering rest of the patchset which does not fix resulting dtbs_check >> warning. > > The existing compatible "sa8775p" warning can only be addressed When > @Nikunj's "sa8775p" changes merged. > > Let me know if you have other suggestions for this. I don't have, because I don't understand why do you want/need to change existing board compatible. Best regards, Krzysztof
On 7/8/2024 2:07 PM, Krzysztof Kozlowski wrote: > On 08/07/2024 06:45, Aiqun Yu (Maria) wrote: >> >> >> On 7/3/2024 5:33 PM, Krzysztof Kozlowski wrote: >>> On 03/07/2024 11:21, Tengfei Fan wrote: >>>>>> - items: >>>>>> - enum: >>>>>> + - qcom,qcs9100-ride >>>>>> - qcom,sa8775p-ride >>>>>> + - const: qcom,qcs9100 >>>>> >>>>> This changes existing compatible for sa8775p without any explanation in >>>>> commit msg. >>>>> >>>>> Best regards, >>>>> Krzysztof >>>>> >>>> >>>> In the next verion patch series, I will provide relevant explanatory >>>> information in this patch commit message. >>> >>> TBH, I cannot think of any reasonable explanation for this, especially >>> considering rest of the patchset which does not fix resulting dtbs_check >>> warning. >> >> The existing compatible "sa8775p" warning can only be addressed When >> @Nikunj's "sa8775p" changes merged. >> >> Let me know if you have other suggestions for this. > > I don't have, because I don't understand why do you want/need to change > existing board compatible. We can left the current existing sa8775p board compatible as it is. And have a brand new qcs9100 and qcs9100-board item for current non-scmi resources compatible. Will that be more reasonable from your end? > > Best regards, > Krzysztof >
On 08/07/2024 09:13, Aiqun Yu (Maria) wrote: > > > On 7/8/2024 2:07 PM, Krzysztof Kozlowski wrote: >> On 08/07/2024 06:45, Aiqun Yu (Maria) wrote: >>> >>> >>> On 7/3/2024 5:33 PM, Krzysztof Kozlowski wrote: >>>> On 03/07/2024 11:21, Tengfei Fan wrote: >>>>>>> - items: >>>>>>> - enum: >>>>>>> + - qcom,qcs9100-ride >>>>>>> - qcom,sa8775p-ride >>>>>>> + - const: qcom,qcs9100 >>>>>> >>>>>> This changes existing compatible for sa8775p without any explanation in >>>>>> commit msg. >>>>>> >>>>>> Best regards, >>>>>> Krzysztof >>>>>> >>>>> >>>>> In the next verion patch series, I will provide relevant explanatory >>>>> information in this patch commit message. >>>> >>>> TBH, I cannot think of any reasonable explanation for this, especially >>>> considering rest of the patchset which does not fix resulting dtbs_check >>>> warning. >>> >>> The existing compatible "sa8775p" warning can only be addressed When >>> @Nikunj's "sa8775p" changes merged. >>> >>> Let me know if you have other suggestions for this. >> >> I don't have, because I don't understand why do you want/need to change >> existing board compatible. > > We can left the current existing sa8775p board compatible as it is. And > have a brand new qcs9100 and qcs9100-board item for current non-scmi > resources compatible. > > Will that be more reasonable from your end? Yes, this is what I would expect. If you choose any other way - just like I wrote - you need to explain why you are doing this. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index ec1c10a12470..f06543f96026 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -45,6 +45,7 @@ description: | qcs8550 qcm2290 qcm6490 + qcs9100 qdu1000 qrb2210 qrb4210 @@ -894,7 +895,9 @@ properties: - items: - enum: + - qcom,qcs9100-ride - qcom,sa8775p-ride + - const: qcom,qcs9100 - const: qcom,sa8775p - items:
Document the QCS9100 SoC and RIDE board. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++ 1 file changed, 3 insertions(+)