| Message ID | 20240707184813.33166-1-080ariel@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cf6ead095babb2df6fb24ee96f5237f8999a7179 |
| Headers | show |
| Series | [v3] gitweb: rss/atom change published/updated date to committer date | expand |
Jesús Ariel Cabello Mateos <080ariel@gmail.com> writes: > ... > Additionally, to be consistent, also use the committer date to > determine the date of the last commit to send in the feed > instead of the author date. > > Signed-off-by: Jesús Ariel Cabello Mateos <080ariel@gmail.com> > --- Nicely done. Will queue. Let me mark the topic for 'next'. Thanks.
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index ccd14e0e30..b09a8d0523 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -8326,10 +8326,10 @@ sub git_feed { my %co = %{$commitlist[$i]}; my $commit = $co{'id'}; # we read 150, we always show 30 and the ones more recent than 48 hours - if (($i >= 20) && ((time - $co{'author_epoch'}) > 48*60*60)) { + if (($i >= 20) && ((time - $co{'committer_epoch'}) > 48*60*60)) { last; } - my %cd = parse_date($co{'author_epoch'}, $co{'author_tz'}); + my %cd = parse_date($co{'committer_epoch'}, $co{'committer_tz'}); # get list of changed files open my $fd, "-|", git_cmd(), "diff-tree", '-r', @diff_opts,
The author date is used for published/updated date in the rss/atom feed stream. Change it to the committer date that betters reflect the "published/updated" definition and makes rss/atom feeds more linear. Gitlab/Github rss/atom feeds use the committer date. Additionally, to be consistent, also use the committer date to determine the date of the last commit to send in the feed instead of the author date. Signed-off-by: Jesús Ariel Cabello Mateos <080ariel@gmail.com> --- Changes since v2: - Fix line wrapping in patch - Also use authored date for processing loop. - Rewrite commit message for clarity. Thank you, Junio! gitweb/gitweb.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)