[net-next,v16,00/14] Introduce PHY listing and link_topology tracking

Message

Maxime Chevallier July 5, 2024, 1:26 p.m. UTC

Hello everyone,

This is V16 of the phy_link_topology series, aiming at improving support
for multiple PHYs being attached to the same MAC.

There are 2 changes in V16 compared to V15 :

 - In patch 4, the sfp_get_name() helper was moved around to better
   match the structure of the file. Russell, I've added a Suggested-by
   tag from you, as I used a description paragraph verbatim from your
   last review.

 - Patches 7 and 8 were reworked so that we don't report the phy id in
   the netlink command PHY_GET, as this is inconsistent between C22 and
   C45, and C45 wasn't even supported.

All other patches are left unchanged from V15, besides a net-next
rebase.

As a remainder, here's what the PHY listings would look like :
 - eth0 has a 88x3310 acting as media converter, and an SFP module with
   an embedded 88e1111 PHY
 - eth2 has a 88e1510 PHY

# ethtool --show-phys *

PHY for eth0:
PHY index: 1
Driver name: mv88x3310
PHY device name: f212a600.mdio-mii:00
Downstream SFP bus name: sfp-eth0
Upstream type: MAC

PHY for eth0:
PHY index: 2
Driver name: Marvell 88E1111
PHY device name: i2c:sfp-eth0:16
Upstream type: PHY
Upstream PHY index: 1
Upstream SFP name: sfp-eth0

PHY for eth2:
PHY index: 1
Driver name: Marvell 88E1510
PHY device name: f212a200.mdio-mii:00
Upstream type: MAC

Ethtool patches : https://github.com/minimaxwell/ethtool/tree/mc/topo-v16

Link to V15: https://lore.kernel.org/netdev/[e-mail]/
Link to V14: https://lore.kernel.org/netdev/[e-mail]/
Link to V13: https://lore.kernel.org/netdev/[e-mail]/
Link to v12: https://lore.kernel.org/netdev/[e-mail]/
Link to v11: https://lore.kernel.org/netdev/[e-mail]/
Link to V10: https://lore.kernel.org/netdev/[e-mail]/
Link to V9: https://lore.kernel.org/netdev/[e-mail]/
Link to V8: https://lore.kernel.org/netdev/[e-mail]/
Link to V7: https://lore.kernel.org/netdev/[e-mail]/
Link to V6: https://lore.kernel.org/netdev/[e-mail]/
Link to V5: https://lore.kernel.org/netdev/[e-mail]/
Link to V4: https://lore.kernel.org/netdev/[e-mail]/
Link to V3: https://lore.kernel.org/netdev/[e-mail]/
Link to V2: https://lore.kernel.org/netdev/[e-mail]/
Link to V1: https://lore.kernel.org/netdev/[e-mail]/

More discussions on specific issues that happened in 6.9-rc:

https://lore.kernel.org/netdev/[e-mail]/
https://lore.kernel.org/netdev/[e-mail]/
https://lore.kernel.org/netdev/[e-mail]/

Maxime Chevallier (14):
  net: phy: Introduce ethernet link topology representation
  net: sfp: pass the phy_device when disconnecting an sfp module's PHY
  net: phy: add helpers to handle sfp phy connect/disconnect
  net: sfp: Add helper to return the SFP bus name
  net: ethtool: Allow passing a phy index for some commands
  netlink: specs: add phy-index as a header parameter
  net: ethtool: Introduce a command to list PHYs on an interface
  netlink: specs: add ethnl PHY_GET command set
  net: ethtool: plca: Target the command to the requested PHY
  net: ethtool: pse-pd: Target the command to the requested PHY
  net: ethtool: cable-test: Target the command to the requested PHY
  net: ethtool: strset: Remove unnecessary check on genl_info
  net: ethtool: strset: Allow querying phy stats by index
  Documentation: networking: document phy_link_topology

 Documentation/netlink/specs/ethtool.yaml      |  58 ++++
 Documentation/networking/ethtool-netlink.rst  |  51 +++
 Documentation/networking/index.rst            |   1 +
 .../networking/phy-link-topology.rst          | 121 +++++++
 MAINTAINERS                                   |   1 +
 drivers/net/phy/Makefile                      |   2 +-
 drivers/net/phy/marvell-88x2222.c             |   2 +
 drivers/net/phy/marvell.c                     |   2 +
 drivers/net/phy/marvell10g.c                  |   2 +
 drivers/net/phy/phy_device.c                  |  48 +++
 drivers/net/phy/phy_link_topology.c           | 105 ++++++
 drivers/net/phy/phylink.c                     |   3 +-
 drivers/net/phy/qcom/at803x.c                 |   2 +
 drivers/net/phy/qcom/qca807x.c                |   2 +
 drivers/net/phy/sfp-bus.c                     |  26 +-
 include/linux/netdevice.h                     |   4 +-
 include/linux/phy.h                           |   6 +
 include/linux/phy_link_topology.h             |  82 +++++
 include/linux/sfp.h                           |   8 +-
 include/uapi/linux/ethtool.h                  |  16 +
 include/uapi/linux/ethtool_netlink.h          |  20 ++
 net/core/dev.c                                |  15 +
 net/ethtool/Makefile                          |   3 +-
 net/ethtool/cabletest.c                       |  35 +-
 net/ethtool/netlink.c                         |  66 +++-
 net/ethtool/netlink.h                         |  33 ++
 net/ethtool/phy.c                             | 308 ++++++++++++++++++
 net/ethtool/plca.c                            |  30 +-
 net/ethtool/pse-pd.c                          |  30 +-
 net/ethtool/strset.c                          |  27 +-
 30 files changed, 1057 insertions(+), 52 deletions(-)
 create mode 100644 Documentation/networking/phy-link-topology.rst
 create mode 100644 drivers/net/phy/phy_link_topology.c
 create mode 100644 include/linux/phy_link_topology.h
 create mode 100644 net/ethtool/phy.c

Comments

Maxime Chevallier July 8, 2024, 1:37 p.m. UTC | #1

On Fri,  5 Jul 2024 15:26:51 +0200
Maxime Chevallier <[e-mail]> wrote:

> Hello everyone,
> 
> This is V16 of the phy_link_topology series, aiming at improving support
> for multiple PHYs being attached to the same MAC.

[...]

> 
> Maxime Chevallier (14):
>   net: phy: Introduce ethernet link topology representation
>   net: sfp: pass the phy_device when disconnecting an sfp module's PHY
>   net: phy: add helpers to handle sfp phy connect/disconnect
>   net: sfp: Add helper to return the SFP bus name
>   net: ethtool: Allow passing a phy index for some commands
>   netlink: specs: add phy-index as a header parameter
>   net: ethtool: Introduce a command to list PHYs on an interface
>   netlink: specs: add ethnl PHY_GET command set

I'll resend this series, as with the very recent merge of Köry's PSE
work [1], the ethtool specs will conflict upon applying the
phy_link_topology work :)

https://lore.kernel.org/netdev/[e-mail]/

Thanks,

Maxime