| Message ID | 20240705152037.1920276-4-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | CI: Fixes, part 2 | expand |
On Fri, Jul 05, 2024 at 04:20:34PM +0100, Andrew Cooper wrote: > Update to Ubuntu 24.04, and checkout@v4 as v2 is deprecated. > > The build step goes out of it's way to exclude docs and stubdom (but include > plain MiniOS), so disable those at the ./configure stage. Since we now disable those at configure time, could the build step be switched to a plain `make build`? Thanks, Roger.
On 08/07/2024 10:16 am, Roger Pau Monné wrote: > On Fri, Jul 05, 2024 at 04:20:34PM +0100, Andrew Cooper wrote: >> Update to Ubuntu 24.04, and checkout@v4 as v2 is deprecated. >> >> The build step goes out of it's way to exclude docs and stubdom (but include >> plain MiniOS), so disable those at the ./configure stage. > Since we now disable those at configure time, could the build step be > switched to a plain `make build`? Yeah, that works. https://github.com/andyhhp/xen/actions/runs/9840942508/job/27166367683 The job failed with I put an explicit exit 1 at the end to avoid uploading to Coverity. This action doesn't have a dry-run option. I'll send out a v2. ~Andrew
diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml index 60ac8dee5570..984636eb4635 100644 --- a/.github/workflows/coverity.yml +++ b/.github/workflows/coverity.yml @@ -8,27 +8,39 @@ on: jobs: coverity: - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 steps: - name: Install build dependencies run: | - sudo apt-get install -y wget git gawk \ - libbz2-dev build-essential \ - zlib1g-dev libncurses5-dev iasl \ - libbz2-dev e2fslibs-dev uuid-dev ocaml \ - ocaml-findlib libyajl-dev \ - autoconf libtool liblzma-dev \ - python3-dev golang libsystemd-dev + sudo apt-get install -y \ + build-essential \ + git-core \ + golang \ + iasl \ + libbz2-dev \ + libext2fs-dev \ + liblzma-dev \ + libncurses5-dev \ + libyajl-dev \ + libzstd-dev \ + ocaml \ + ocaml-findlib \ + python3-dev \ + uuid-dev \ + zlib1g-dev \ - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: ref: staging - name: Configure Xen run: | - ./configure --with-system-qemu=/bin/true \ - --with-system-seabios=/bin/true \ - --with-system-ovmf=/bin/true + ./configure \ + --disable-docs \ + --disable-stubdom \ + --with-system-qemu=/bin/true \ + --with-system-seabios=/bin/true \ + --with-system-ovmf=/bin/true \ - name: Pre build stuff run: |
Update to Ubuntu 24.04, and checkout@v4 as v2 is deprecated. The build step goes out of it's way to exclude docs and stubdom (but include plain MiniOS), so disable those at the ./configure stage. Refresh the package list. libbz2-dev was in there twice, and e2fslibs-dev is a a transitional package to libext2fs-dev. I'm not aware of libtool ever having been a Xen dependency. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Anthony PERARD <anthony.perard@vates.tech> CC: Juergen Gross <jgross@suse.com> CC: Roger Pau Monné <roger.pau@citrix.com> CC: Jan Beulich <JBeulich@suse.com> CC: Stefano Stabellini <sstabellini@kernel.org> CC: Julien Grall <julien@xen.org> CC: Oleksii Kurochko <oleksii.kurochko@gmail.com> --- .github/workflows/coverity.yml | 36 ++++++++++++++++++++++------------ 1 file changed, 24 insertions(+), 12 deletions(-)