| Message ID | fc69b94aad4bbe568dcf9ef7aa73f9bac685142c.1720512888.git.0x1207@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: stmmac: refactor FPE for gmac4 and xgmac | expand |
On Tue, Jul 09, 2024 at 04:21:25PM +0800, Furong Xu wrote: > Frame Preemption Interrupt is required to finish FPE handshake. > > XGMAC_FPEIE is read-only reserved if FPE is not supported by HW. > There is no harm that we always set XGMAC_FPEIE bit. This is better, it explains what is going on, why the change is being made. But when i see this, i think about the interrupt handler. You don't just enable a new interrupt, you also need to handle the interrupt. Where is that handler code? The commit message is the place you try to answer the questions reviewers are going to ask. So if the interrupt handler already looks for this interrupt cause and handles it, add a statement to the commit message explaining it. Andrew
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h index c66fa6040672..f359d70beb83 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h @@ -96,10 +96,11 @@ #define XGMAC_LPIIS BIT(5) #define XGMAC_PMTIS BIT(4) #define XGMAC_INT_EN 0x000000b4 +#define XGMAC_FPEIE BIT(15) #define XGMAC_TSIE BIT(12) #define XGMAC_LPIIE BIT(5) #define XGMAC_PMTIE BIT(4) -#define XGMAC_INT_DEFAULT_EN (XGMAC_LPIIE | XGMAC_PMTIE) +#define XGMAC_INT_DEFAULT_EN (XGMAC_FPEIE | XGMAC_LPIIE | XGMAC_PMTIE) #define XGMAC_Qx_TX_FLOW_CTRL(x) (0x00000070 + (x) * 4) #define XGMAC_PT GENMASK(31, 16) #define XGMAC_PT_SHIFT 16
Frame Preemption Interrupt is required to finish FPE handshake. XGMAC_FPEIE is read-only reserved if FPE is not supported by HW. There is no harm that we always set XGMAC_FPEIE bit. Signed-off-by: Furong Xu <0x1207@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)