| Message ID | 20240709-add_qcs9100_pcie_compatible-v2-1-04f1e85c8a48@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | PCI: qcom: Add QCS9100 PCIe compatible | expand |
On Tue, Jul 09, 2024 at 10:59:29PM +0800, Tengfei Fan wrote: > Document compatible for QCS9100 platform. Add blank line for paragraph breaks. > QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p > platform use non-SCMI resource. In the future, the SA8775p platform will > move to use SCMI resources and it will have new sa8775p-related device > tree. Consequently, introduce "qcom,pcie-qcs9100" to describe non-SCMI > based PCIe. Not connected to the patch below. Move to where it is relevant. > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > --- > Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml > index efde49d1bef8..4de33df6963f 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml > @@ -16,7 +16,10 @@ description: > > properties: > compatible: > - const: qcom,pcie-sa8775p > + items: > + - enum: > + - qcom,pcie-qcs9100 > + - qcom,pcie-sa8775p > > reg: > minItems: 6 > > -- > 2.25.1 >
On 7/10/2024 12:29 AM, Bjorn Helgaas wrote: > On Tue, Jul 09, 2024 at 10:59:29PM +0800, Tengfei Fan wrote: >> Document compatible for QCS9100 platform. > > Add blank line for paragraph breaks. A blank line will be added in the next verion patch series. > >> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p >> platform use non-SCMI resource. In the future, the SA8775p platform will >> move to use SCMI resources and it will have new sa8775p-related device >> tree. Consequently, introduce "qcom,pcie-qcs9100" to describe non-SCMI >> based PCIe. > > Not connected to the patch below. Move to where it is relevant. As mentioned in the cover letter, we will also push the QCS9100 device tree patch series to upstream after all the binding and driver patches are reviewd. The QCS9100 device tree is directly renamed from the SA8775p device tree. This comment message serves to explain why we need to push this PCIe binding patch, thus avoiding any questions from reviews about why we are not continuing to use the "qcom,pcie-sa8775p" compatible name. If you still think that this comment message is not necessay here, I will move this comment message from binding and driver patches to the cover letter. > >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- >> Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml >> index efde49d1bef8..4de33df6963f 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml >> @@ -16,7 +16,10 @@ description: >> >> properties: >> compatible: >> - const: qcom,pcie-sa8775p >> + items: >> + - enum: >> + - qcom,pcie-qcs9100 >> + - qcom,pcie-sa8775p >> >> reg: >> minItems: 6 >> >> -- >> 2.25.1 >>
On 7/10/2024 2:37 PM, Tengfei Fan wrote: > > > On 7/10/2024 12:29 AM, Bjorn Helgaas wrote: >> On Tue, Jul 09, 2024 at 10:59:29PM +0800, Tengfei Fan wrote: >>> Document compatible for QCS9100 platform. >> >> Add blank line for paragraph breaks. > > A blank line will be added in the next verion patch series. > >> >>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p >>> platform use non-SCMI resource. In the future, the SA8775p platform will >>> move to use SCMI resources and it will have new sa8775p-related device >>> tree. Consequently, introduce "qcom,pcie-qcs9100" to describe non-SCMI >>> based PCIe. >> >> Not connected to the patch below. Move to where it is relevant. > > As mentioned in the cover letter, we will also push the QCS9100 device > tree patch series to upstream after all the binding and driver patches > are reviewd. The QCS9100 device tree is directly renamed from the > SA8775p device tree. > > This comment message serves to explain why we need to push this PCIe > binding patch, thus avoiding any questions from reviews about why we are > not continuing to use the "qcom,pcie-sa8775p" compatible name. > > If you still think that this comment message is not necessay here, I > will move this comment message from binding and driver patches to the > cover letter. After considering the feedback provided on the subject, We have decided to keep current SA8775p compatible and ABI compatibility in drivers. Let's close this session and ignore all the current patches here. Thank you for your input. > >> >>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml >>> b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml >>> index efde49d1bef8..4de33df6963f 100644 >>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml >>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml >>> @@ -16,7 +16,10 @@ description: >>> properties: >>> compatible: >>> - const: qcom,pcie-sa8775p >>> + items: >>> + - enum: >>> + - qcom,pcie-qcs9100 >>> + - qcom,pcie-sa8775p >>> reg: >>> minItems: 6 >>> >>> -- >>> 2.25.1 >>> >
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml index efde49d1bef8..4de33df6963f 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml @@ -16,7 +16,10 @@ description: properties: compatible: - const: qcom,pcie-sa8775p + items: + - enum: + - qcom,pcie-qcs9100 + - qcom,pcie-sa8775p reg: minItems: 6
Document compatible for QCS9100 platform. QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p platform use non-SCMI resource. In the future, the SA8775p platform will move to use SCMI resources and it will have new sa8775p-related device tree. Consequently, introduce "qcom,pcie-qcs9100" to describe non-SCMI based PCIe. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)