| Message ID | 20240709-add_qcs9100_dwmac_sgmii_hpy_compatible-v2-1-5ffeb16252db@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | phy: qcom: Add QCS9100 dwmac sgmii phy compatible | expand |
On 09/07/2024 17:15, Tengfei Fan wrote: > Document the Qualcomm SGMII PHY for the QCS9100 platforms. > QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p > platform use non-SCMI resource. In the future, the SA8775p platform will > move to use SCMI resources and it will have new sa8775p-related device > tree. Consequently, introduce "qcom,qcs9100-dwmac-sgmii-phy" to describe > non-SCMI based the Qualcomm SGMII PHY. > > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > --- > .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml > index b9107759b2a5..74ec4579c0d6 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml > @@ -15,7 +15,10 @@ description: > > properties: > compatible: > - const: qcom,sa8775p-dwmac-sgmii-phy > + items: items is not needed here, this could be an enum directly. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 7/10/2024 6:13 PM, Krzysztof Kozlowski wrote: > On 09/07/2024 17:15, Tengfei Fan wrote: >> Document the Qualcomm SGMII PHY for the QCS9100 platforms. >> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p >> platform use non-SCMI resource. In the future, the SA8775p platform will >> move to use SCMI resources and it will have new sa8775p-related device >> tree. Consequently, introduce "qcom,qcs9100-dwmac-sgmii-phy" to describe >> non-SCMI based the Qualcomm SGMII PHY. >> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- >> .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml >> index b9107759b2a5..74ec4579c0d6 100644 >> --- a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml >> @@ -15,7 +15,10 @@ description: >> >> properties: >> compatible: >> - const: qcom,sa8775p-dwmac-sgmii-phy >> + items: > > items is not needed here, this could be an enum directly. > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks Krzysztof! In the next version patch series, I will check all the patch series, using an enum instead od items. > > > > Best regards, > Krzysztof >
On 7/11/2024 11:52 AM, Tengfei Fan wrote: > > > On 7/10/2024 6:13 PM, Krzysztof Kozlowski wrote: >> On 09/07/2024 17:15, Tengfei Fan wrote: >>> Document the Qualcomm SGMII PHY for the QCS9100 platforms. >>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p >>> platform use non-SCMI resource. In the future, the SA8775p platform will >>> move to use SCMI resources and it will have new sa8775p-related device >>> tree. Consequently, introduce "qcom,qcs9100-dwmac-sgmii-phy" to describe >>> non-SCMI based the Qualcomm SGMII PHY. >>> >>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >>> --- >>> >>> .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml >>> | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml >>> index b9107759b2a5..74ec4579c0d6 100644 >>> --- >>> a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml >>> +++ >>> b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml >>> @@ -15,7 +15,10 @@ description: >>> properties: >>> compatible: >>> - const: qcom,sa8775p-dwmac-sgmii-phy >>> + items: >> >> items is not needed here, this could be an enum directly. >> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Thanks Krzysztof! > > In the next version patch series, I will check all the patch series, > using an enum instead od items. After considering the feedback provided on the subject, We have decided to keep current SA8775p compatible and ABI compatibility in drivers. Let's close this session and ignore all the current patches here. Thank you for your input. > >> >> >> >> Best regards, >> Krzysztof >> >
diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml index b9107759b2a5..74ec4579c0d6 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml @@ -15,7 +15,10 @@ description: properties: compatible: - const: qcom,sa8775p-dwmac-sgmii-phy + items: + - enum: + - qcom,qcs9100-dwmac-sgmii-phy + - qcom,sa8775p-dwmac-sgmii-phy reg: items:
Document the Qualcomm SGMII PHY for the QCS9100 platforms. QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p platform use non-SCMI resource. In the future, the SA8775p platform will move to use SCMI resources and it will have new sa8775p-related device tree. Consequently, introduce "qcom,qcs9100-dwmac-sgmii-phy" to describe non-SCMI based the Qualcomm SGMII PHY. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)