| Message ID | 20240710185743.709742-2-thorsten.blum@toblux.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 215a19631d1125a2834b2ffe62b8de9a9e73d6a8 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: ath9k: Use swap() to improve ath9k_hw_get_nf_hist_mid() | expand |
Thorsten Blum <thorsten.blum@toblux.com> writes: > Use the swap() macro to simplify the ath9k_hw_get_nf_hist_mid() function > and improve its readability. > > Fixes the following Coccinelle/coccicheck warning reported by > swap.cocci: > > WARNING opportunity for swap() > > Compile-tested only. > > Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com> Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
Thorsten Blum <thorsten.blum@toblux.com> wrote: > Use the swap() macro to simplify the ath9k_hw_get_nf_hist_mid() function > and improve its readability. > > Fixes the following Coccinelle/coccicheck warning reported by > swap.cocci: > > WARNING opportunity for swap() > > Compile-tested only. > > Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com> > Acked-by: Toke Høiland-Jørgensen <toke@toke.dk> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Patch applied to ath-next branch of ath.git, thanks. 215a19631d11 wifi: ath9k: Use swap() to improve ath9k_hw_get_nf_hist_mid()
diff --git a/drivers/net/wireless/ath/ath9k/calib.c b/drivers/net/wireless/ath/ath9k/calib.c index fb270df75eb2..4b331c85509c 100644 --- a/drivers/net/wireless/ath/ath9k/calib.c +++ b/drivers/net/wireless/ath/ath9k/calib.c @@ -32,11 +32,8 @@ static int16_t ath9k_hw_get_nf_hist_mid(int16_t *nfCalBuffer) for (i = 0; i < ATH9K_NF_CAL_HIST_MAX - 1; i++) { for (j = 1; j < ATH9K_NF_CAL_HIST_MAX - i; j++) { - if (sort[j] > sort[j - 1]) { - nfval = sort[j]; - sort[j] = sort[j - 1]; - sort[j - 1] = nfval; - } + if (sort[j] > sort[j - 1]) + swap(sort[j], sort[j - 1]); } } nfval = sort[(ATH9K_NF_CAL_HIST_MAX - 1) >> 1];
Use the swap() macro to simplify the ath9k_hw_get_nf_hist_mid() function and improve its readability. Fixes the following Coccinelle/coccicheck warning reported by swap.cocci: WARNING opportunity for swap() Compile-tested only. Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com> --- drivers/net/wireless/ath/ath9k/calib.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)